Skip to content

Bind Firestore handoff to exact legacy artifact bytes - #142

Merged
Pigbibi merged 3 commits into
mainfrom
codex/qsl-p4-slice1-cryptolive-exact-bytes-firestore-handoff-20260804
Aug 4, 2026
Merged

Bind Firestore handoff to exact legacy artifact bytes#142
Pigbibi merged 3 commits into
mainfrom
codex/qsl-p4-slice1-cryptolive-exact-bytes-firestore-handoff-20260804

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • add a versioned live_pool_legacy_exact_bytes Firestore handoff carrying the exact UTF-8 text read from artifacts.live_pool_legacy_path
  • fail closed on missing/invalid UTF-8/JSON/non-object bytes, artifact/runtime-identity digest mismatch, or convenience-field mismatch
  • cover exact whitespace preservation, one-byte mutation, symbol/map mismatch, and invalid fixture cases offline

Why

The existing Firestore payload reconstructs symbols and symbol_map but does not carry the exact live_pool_legacy.json bytes bound by runtime_evidence_identity.artifacts.live_pool_legacy.sha256.

Validation

  • focused release-contract suite: 16 tests passed
  • full offline unit suite: 67 tests passed
  • Ruff changed/full: passed
  • compileall: passed
  • package build and installed-package check: passed
  • scope/diff/secret checks: passed
  • uv lock --check: pre-existing failure reproduced unchanged on clean origin/main; dependency/lock changes are outside this PR

Boundary

Producer half only. No Binance change, provider/cloud call, publish, workflow dispatch/rerun, runtime/deploy/config-sync, credential access, broker/order/capital/paper/shadow/live action, or merge is authorized by this PR.

Co-Authored-By: Codex <noreply@openai.com>

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2fb6e5ffe5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/publish.py Outdated
Comment thread src/publish.py
Co-Authored-By: Codex <noreply@openai.com>

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3c45968b9e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/publish.py
Co-Authored-By: Codex <noreply@openai.com>
@Pigbibi
Pigbibi merged commit 3982b53 into main Aug 4, 2026
4 checks passed
@Pigbibi
Pigbibi deleted the codex/qsl-p4-slice1-cryptolive-exact-bytes-firestore-handoff-20260804 branch August 4, 2026 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant