Skip to content

chore: update strategy dependency pins - #192

Merged
Pigbibi merged 2 commits into
mainfrom
codex/update-strategy-pins-20260703
Jul 3, 2026
Merged

chore: update strategy dependency pins#192
Pigbibi merged 2 commits into
mainfrom
codex/update-strategy-pins-20260703

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Summary\n- update strategy package pin to a version that depends on QPK 0063af3\n- fixes deploy pip conflict between platform QPK pin and strategy package QPK pin\n\n## Tests\n- python3.11 scripts/check_qpk_pin_consistency.py

Co-Authored-By: Codex <noreply@openai.com>

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b45db80232

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread requirements.txt
requests
quant-platform-kit @ git+https://github.com/QuantStrategyLab/QuantPlatformKit.git@0063af3b4a974650ea58a7d3f26dd1b94f65d3e8
us-equity-strategies @ git+https://github.com/QuantStrategyLab/UsEquityStrategies.git@64342a1e95a687c29a2be6f0b771e4a7be15b8b8
us-equity-strategies @ git+https://github.com/QuantStrategyLab/UsEquityStrategies.git@46887bc3f5454d5b59623b1f5efb7c65912c6b8b

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep constraints in sync with strategy pin

This updates requirements.txt to UsEquityStrategies commit 46887bc..., but constraints.txt still constrains us-equity-strategies to 64342a... even though it is labeled the single source of truth for git-based SHAs and prior strategy-pin updates changed both files. Any install path that applies the repo constraints alongside these requirements via pip's -c/--constraint option now supplies two different direct refs for the same package, so the dependency pin can be rejected or installed inconsistently; update constraints.txt with the same strategy SHA.

Useful? React with 👍 / 👎.

@Pigbibi
Pigbibi enabled auto-merge (squash) July 3, 2026 05:24
Co-Authored-By: Codex <noreply@openai.com>
@Pigbibi
Pigbibi merged commit d438f7f into main Jul 3, 2026
2 checks passed
@Pigbibi
Pigbibi deleted the codex/update-strategy-pins-20260703 branch July 3, 2026 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant