Fix shadow execution report identity - #362
Merged
Merged
Conversation
Co-Authored-By: Codex <noreply@openai.com>
Pigbibi
marked this pull request as ready for review
July 31, 2026 02:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Root cause
The shadow runtime reused a live account group. Report assembly inherited that group's live service name and account scope, so Execution Report Heartbeat correctly rejected the shadow report.
Impact
Future shadow reports identify the shadow Cloud Run service and
us-combo-shadowscope without changing broker routing, positions, orders, or execution mode.Validation
python -m pytest -q tests/test_runtime_config_support.py tests/test_runtime_composer.py tests/test_request_handling.py tests/test_execution_report_heartbeat.py tests/test_runtime_heartbeat_policy.py— 158 passedpython -m ruff check runtime_config_support.py application/runtime_composer.py tests/test_runtime_config_support.py tests/test_runtime_composer.py— passedgit diff --check— passedNo
/runor/dry-runendpoint was triggered.