refactor(snapshot): remove strategy reverse dependency - #213
Conversation
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
Co-Authored-By: Codex <noreply@openai.com>
3d4b808 to
f358059
Compare
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f3580593b3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| return str(resolve_canonical_profile(label)).strip() | ||
| except Exception: | ||
| return label | ||
| return normalize_profile_name(str(value or "").strip()) |
There was a problem hiding this comment.
This helper now only lowercases labels, so the guard still accepts a retired config alias whenever the caller's expectation is also that alias. In the runtime path, expected_config_name is taken from merged_runtime_config['runtime_config_name']; if an old config still names itself tech_pullback_cash_buffer while the manifest has canonical strategy_profile but aliased config_name, the comparison at the config-name guard sees identical normalized aliases and proceeds, despite the new contract requiring manifest/config names to be canonical. Canonicalize or validate the expected config name before comparing so stale config aliases fail closed.
Useful? React with 👍 / 👎.
1 participant
Part of the QuantStrategyLab P0-P5 hardening and convergence wave.
Highlights:
Local validation was run before push in the Codex execution session.