Skip to content

fix: preserve caller lifecycle context in reusable drift checks - #230

Merged
Pigbibi merged 3 commits into
mainfrom
codex/reusable-drift-preflight-handoff
Jul 10, 2026
Merged

fix: preserve caller lifecycle context in reusable drift checks#230
Pigbibi merged 3 commits into
mainfrom
codex/reusable-drift-preflight-handoff

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Summary

  • pass the caller lifecycle bucket into the reusable workflow explicitly
  • pin QPK checkout through a caller-supplied ref
  • route drift issues back to the caller repository

Validation

  • python3 -m pytest -q tests/test_reusable_drift_workflow.py
  • actionlint .github/workflows/reusable-drift-check.yml

Co-Authored-By: Codex <noreply@openai.com>
@github-actions

github-actions Bot commented Jul 10, 2026

Copy link
Copy Markdown

🤖 Codex PR Review

Merge allowed: No issues found


Review by Codex PR Review bot • PR

Pigbibi and others added 2 commits July 11, 2026 03:47
Co-Authored-By: Codex <noreply@openai.com>
Co-Authored-By: Codex <noreply@openai.com>
@Pigbibi
Pigbibi merged commit 17278db into main Jul 10, 2026
3 checks passed
@Pigbibi
Pigbibi deleted the codex/reusable-drift-preflight-handoff branch July 10, 2026 19:51

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ae0c9d7fdd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

quant_platform_kit_ref:
required: false
type: string
default: "main"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep the default checkout pinned to the called workflow

When a caller pins this reusable workflow by SHA or tag but does not pass the new optional quant_platform_kit_ref, this default makes the job install whatever QuantPlatformKit code is on main instead of the workflow version the caller invoked. That reintroduces a moving dependency for scheduled drift checks and can break previously pinned callers when main later changes incompatibly; the fallback should stay tied to the called workflow SHA/ref or the input should be required.

Useful? React with 👍 / 👎.

drift_issue_repository:
required: false
type: string
default: "AuditOrchestrator"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Default drift issues to the caller repo

In runs where a caller does not pass the new optional drift_issue_repository, this default still directs gh issue create at QuantStrategyLab/AuditOrchestrator while the workflow uses the caller repository's GITHUB_TOKEN. That either sends drift alerts to the wrong tracker or fails when the caller token cannot write to the orchestrator repo; the default path should derive the repository from the caller context unless an override is explicitly supplied.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant