Skip to content

feat: add immutable deployment bundle contract - #202

Merged
Pigbibi merged 1 commit into
mainfrom
codex/qsl-p0-deployment-bundle-v1-fresh-base-rebuild-20260805
Aug 4, 2026
Merged

feat: add immutable deployment bundle contract#202
Pigbibi merged 1 commit into
mainfrom
codex/qsl-p0-deployment-bundle-v1-fresh-base-rebuild-20260805

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add the strict, dependency-free DeploymentBundle v1 schema and validator
  • bind strategy source revision to the declared strategy dependency before digest verification
  • reject impossible RFC3339 UTC calendar timestamps and preserve fail-closed synthetic coverage

Validation

  • PYTHONPATH=python python3 -m pytest -q python/tests/test_deployment_bundle_contract.py
  • python3 -m unittest discover -s python/tests -v
  • runtime/config, schema, compile, package, actionlint, Node, matrix, scope, and secret gates

Co-Authored-By: Codex <noreply@openai.com>
@Pigbibi
Pigbibi merged commit 4029144 into main Aug 4, 2026
6 checks passed
@Pigbibi
Pigbibi deleted the codex/qsl-p0-deployment-bundle-v1-fresh-base-rebuild-20260805 branch August 4, 2026 16:21

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 768457d4ec

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

"properties": {
"schema": {"const": "qsl.deployment_bundle.v1"},
"bundle_id": {"$ref": "#/$defs/identity"},
"created_at": {"type": "string", "format": "date-time", "pattern": "^[0-9]{4}-[0-9]{2}-[0-9]{2}T[0-9]{2}:[0-9]{2}:[0-9]{2}Z$"},

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Enforce calendar-valid timestamps in the shared schema

When a downstream consumer validates bundles using this shared Draft 2020-12 schema alone, format is annotation-only unless the validator explicitly enables format assertions, and the regex accepts impossible dates such as 2026-13-01T00:00:00Z. Such a bundle therefore passes the schema but fails _expect_timestamp, creating inconsistent contract behavior across consumers; require format assertion in the documented validation path or otherwise enforce calendar validity for schema consumers.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant