Implement ed module - #38
Merged
Merged
Conversation
trvto
requested changes
Sep 17, 2024
trvto
left a comment
trvto
left a comment
Collaborator
There was a problem hiding this comment.
It looks good, just need to clean up the docstrings a bit, then I would approve.
Also, I will add some issues for some things that should be cleaned up/improved at some point
Collaborator
|
Also, it looks like there is a conflict within the |
Collaborator
|
Please also update the package version to |
trvto
self-requested a review
September 20, 2024 13:01
trvto
previously approved these changes
Sep 20, 2024
trvto
self-requested a review
September 20, 2024 14:12
trvto
approved these changes
Sep 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented higher orders.