Skip to content

fix: Fix inout updates for overloaded functions in a comptime context - #1981

Merged
tatiana-s merged 4 commits into
mainfrom
ts/comptime-overload
Jul 2, 2026
Merged

fix: Fix inout updates for overloaded functions in a comptime context#1981
tatiana-s merged 4 commits into
mainfrom
ts/comptime-overload

Conversation

@tatiana-s

Copy link
Copy Markdown
Contributor

Closes #1920

@tatiana-s
tatiana-s requested a review from a team as a code owner July 1, 2026 13:33
@tatiana-s
tatiana-s requested a review from doug-q July 1, 2026 13:33
@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

🐰 Bencher Report

Branchts/comptime-overload
TestbedLinux
Click to view all benchmark results
Benchmarkhugr_bytesBenchmark Result
bytes x 1e3
(Result Δ%)
Upper Boundary
bytes x 1e3
(Limit %)
hugr_nodesBenchmark Result
nodes
(Result Δ%)
Upper Boundary
nodes
(Limit %)
tests/benchmarks/test_big_array.py::test_big_array_compile📈 view plot
🚷 view threshold
120.67 x 1e3
(0.00%)Baseline: 120.67 x 1e3
121.87 x 1e3
(99.01%)
📈 view plot
🚷 view threshold
5,659.00
(0.00%)Baseline: 5,659.00
5,715.59
(99.01%)
tests/benchmarks/test_ctrl_flow.py::test_many_ctrl_flow_compile📈 view plot
🚷 view threshold
36.19 x 1e3
(0.00%)Baseline: 36.19 x 1e3
36.55 x 1e3
(99.01%)
📈 view plot
🚷 view threshold
1,582.00
(0.00%)Baseline: 1,582.00
1,597.82
(99.01%)
tests/benchmarks/test_queue_push_pop.py::test_queue_push_benchmark_compile📈 view plot
🚷 view threshold
9.95 x 1e3
(0.00%)Baseline: 9.95 x 1e3
10.05 x 1e3
(99.01%)
📈 view plot
🚷 view threshold
347.00
(0.00%)Baseline: 347.00
350.47
(99.01%)
tests/benchmarks/test_queue_push_pop.py::test_queue_push_pop_benchmark_compile📈 view plot
🚷 view threshold
14.11 x 1e3
(0.00%)Baseline: 14.11 x 1e3
14.25 x 1e3
(99.01%)
📈 view plot
🚷 view threshold
470.00
(0.00%)Baseline: 470.00
474.70
(99.01%)
🐰 View full continuous benchmarking report in Bencher

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.23810% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 93.04%. Comparing base (b5ca042) to head (2bc0916).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...s/src/guppylang_internals/definition/overloaded.py 91.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1981   +/-   ##
=======================================
  Coverage   93.03%   93.04%           
=======================================
  Files         152      152           
  Lines       14596    14615   +19     
=======================================
+ Hits        13580    13598   +18     
- Misses       1016     1017    +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed-hq

codspeed-hq Bot commented Jul 1, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 11 untouched benchmarks


Comparing ts/comptime-overload (2bc0916) with main (0b3a021)

Open in CodSpeed

@tatiana-s tatiana-s added the B-backport-nominated A PR (or an issue pending a PR) that is nominated for backporting to the previous minor series. label Jul 1, 2026
@tatiana-s tatiana-s modified the milestone: guppylang v1.0 Jul 1, 2026
@tatiana-s
tatiana-s requested review from croyzor and removed request for doug-q July 2, 2026 08:49

@croyzor croyzor left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@tatiana-s
tatiana-s added this pull request to the merge queue Jul 2, 2026
Merged via the queue into main with commit bcd97b6 Jul 2, 2026
17 checks passed
@tatiana-s
tatiana-s deleted the ts/comptime-overload branch July 2, 2026 10:15
@maximilianruesch maximilianruesch added B-backport-accepted A PR (or issue pending a PR) that has been accepted for backporting to the previous minor series. and removed B-backport-nominated A PR (or an issue pending a PR) that is nominated for backporting to the previous minor series. labels Jul 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

B-backport-accepted A PR (or issue pending a PR) that has been accepted for backporting to the previous minor series.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Comptime inout updates don't work with overloaded functions

4 participants