feat!: ConvexChecker is a trait - #121
Merged
Merged
Conversation
lmondada
force-pushed
the
feat/convex-trait
branch
from
December 13, 2023 18:50
47459e2 to
f83b821
Compare
lmondada
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #121 +/- ##
=======================================
Coverage 78.30% 78.30%
=======================================
Files 19 19
Lines 4862 4862
Branches 4862 4862
=======================================
Hits 3807 3807
Misses 979 979
Partials 76 76 ☔ View full report in Codecov by Sentry. |
aborgna-q
enabled auto-merge
December 14, 2023 12:05
Merged
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Dec 14, 2023
## 🤖 New release * `portgraph`: 0.10.0 -> 0.11.0 (⚠️ API breaking changes) ###⚠️ `portgraph` breaking changes ``` --- failure struct_missing: pub struct removed or renamed --- Description: A publicly-visible struct cannot be imported by its prior path. A `pub use` may have been removed, or the struct itself may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.26.0/src/lints/struct_missing.ron Failed in: struct portgraph::algorithms::ConvexChecker, previously in file /tmp/.tmpJ6AwWP/portgraph/src/algorithms/convex.rs:15 ``` <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## 0.11.0 (2023-12-14) ### Documentation - Coverage check section in DEVELOPMENT.md ([#117](#117)) ### Features - [**breaking**] ConvexChecker is a trait ([#121](#121)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/). --------- Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Agustín Borgna <121866228+aborgna-q@users.noreply.github.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
ConvexCheckerrenamed toTopoConvexChecker.