deps: Widen numpy, llvmlite, pyyaml, pydantic dependencies. Bump minimum ziglang and lief. - #204
Conversation
jake-arkinstall
commented
Aug 13, 2026
jake-arkinstall
commented
- The ziglang bump is required for opaque pointer support
- The LIEF bump is required for COFF support
…glang (opaque pointer support) and LIEF (COFF support)
There was a problem hiding this comment.
Pull request overview
This PR updates dependency constraints for the Selene workspace, motivated by newer ziglang (opaque pointer support) and newer LIEF (COFF support), while also adjusting a few Python library version ranges.
Changes:
- Bump
ziglangminimum to~=0.16and bump/pinliefto~=0.17inselene-core. - Adjust
llvmlite,pydantic, andpyyamlconstraints inselene-core. - Widen the top-level
numpyconstraint from>=2.2.6to~=2.0inselene-sim.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
selene-core/pyproject.toml |
Updates core dependency constraints (LIEF/ziglang bumps; llvmlite/pydantic/pyyaml range changes). |
pyproject.toml |
Widens the top-level numpy requirement for selene-sim. |
Suppressed comments (2)
selene-core/pyproject.toml:17
- Runtime depends on
pydantic~=2.12, which allows 2.12.0–2.12.4, but the build-system explicitly requirespydantic>=2.12.5. If 2.12.5 is required for known fixes, the runtime constraint should keep the same minimum (while still allowing future 2.x).
"pydantic~=2.12",
selene-core/pyproject.toml:19
- Lowering PyYAML to
>=5.0may allow very old releases that lack wheels/support for newer Python versions, increasing installation failures (source builds) and diverging from the root package'spyyaml>=6.0.2. Consider keeping a modern minimum here as well.
"pyyaml>=5.0",
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d7eb750cd7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "pyyaml>=5.0", | ||
| "typing_extensions>=4", | ||
| "ziglang~=0.13", | ||
| "ziglang~=0.16", |
There was a problem hiding this comment.
On macOS 11, this new minimum makes selene-core un-installable: the repository explicitly targets macOS 11 via MACOSX_DEPLOYMENT_TARGET = "11.0" in pyproject.toml, but the resolved ziglang 0.16 package has no source distribution and its only macOS wheels are tagged macosx_12_0 (uv.lock lines 1666–1671). The previous constraint allowed pip to backtrack to a compatible older Zig release; retain a platform-specific older constraint or raise the project's macOS deployment target consistently.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
If anyone wants a laugh, look at the copilot session. It's like an excited puppy, full of energy ready to unleash, but no clue where to channel it.
A recent Ruff ruleset expansion started failing CI on existing code paths, creating merge friction across active branches. This PR pins rust to an older version so that we can ignore the new rules for now. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: jake-arkinstall <65358059+jake-arkinstall@users.noreply.github.com>
Co-authored-by: jake-arkinstall <65358059+jake-arkinstall@users.noreply.github.com>
This reverts commit 5c2cd96. Co-authored-by: jake-arkinstall <65358059+jake-arkinstall@users.noreply.github.com>
…te workaround Co-authored-by: jake-arkinstall <65358059+jake-arkinstall@users.noreply.github.com>
…ndling Co-authored-by: jake-arkinstall <65358059+jake-arkinstall@users.noreply.github.com>
🤖 I have created a release *beep* *boop* --- ## [0.3.1](selene-core-v0.3.0...selene-core-v0.3.1) (2026-09-07) ### Dependencies * Widen numpy, llvmlite, pyyaml, pydantic dependencies. Bump minimum ziglang and lief. ([#204](#204)) ([0e8aea3](0e8aea3)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
🤖 I have created a release *beep* *boop* --- ## [0.3.1](selene-sim-v0.3.0...selene-sim-v0.3.1) (2026-09-07) ### Features * backtraces on panic ([#210](#210)) ([9f89a02](9f89a02)) * Modify inter-shot random_seed behaviour, provide legacy behaviour through seed_mode ([#209](#209)) ([d71751a](d71751a)) * Support sol ___future_measure ([#213](#213)) ([eb527d5](eb527d5)) ### Dependencies * Widen numpy, llvmlite, pyyaml, pydantic dependencies. Bump minimum ziglang and lief. ([#204](#204)) ([0e8aea3](0e8aea3)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: Jake Arkinstall <65358059+jake-arkinstall@users.noreply.github.com>
