Skip to content

Migrate chassis packet path to TransportPacket (#138 cycle 1) - #248

Merged
cryptoxdog merged 6 commits into
mainfrom
agent/cursor/ceg-138-transport-packet
Aug 30, 2026
Merged

Migrate chassis packet path to TransportPacket (#138 cycle 1)#248
cryptoxdog merged 6 commits into
mainfrom
agent/cursor/ceg-138-transport-packet

Conversation

@cryptoxdog

Copy link
Copy Markdown
Collaborator

Summary

  • inflate_ingress / deflate_egress / delegate_to_node and PacketBridge now return constellation_node_sdk.TransportPacket.
  • Deleted 16 of 18 packet-envelope.yml ledger entries in the same change. Remaining: tests/unit/test_packet_envelope.py (declaration-type unit tests).
  • Packet-envelope gate: passed=true, new_total=0, known_total=2.

Refs #138

Issue-Remediation-Cycle: #138/cycle-1

Test plan

  • pytest tests/unit/test_chassis_contract.py tests/unit/test_packet_bridge.py tests/unit/test_packet_envelope.py
  • pytest tests/compliance/test_hipaa.py
  • python tools/packet_envelope_gate.py (pass, 2 known leftovers)
  • CI baseline ratchet + unit on this PR

Made with Cursor

Shrinks Cognitive.Engine.Graphs#138 ledger from 18 entries to the two
remaining PacketEnvelope unit-test references. inflate/deflate/delegate
and PacketBridge now return constellation TransportPacket.

Issue-Remediation-Cycle: #138/cycle-1
Co-authored-by: Cursor <cursoragent@cursor.com>
@github-actions

github-actions Bot commented Aug 30, 2026

Copy link
Copy Markdown

⚠️ Large PR Warning
Reviewable lines changed: 705
Warning threshold: 300 lines
Consider splitting for easier review

📋 Best Practices for Large Changes

  1. Refactoring + Features: Separate into 2 PRs
  2. Multiple Features: One PR per feature
  3. Database + Code: Separate migration from logic
  4. Generated Code: Exclude it from reviewable-size accounting

This PR passes the blocking limit but is larger than recommended.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 30, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-08-30T19:08:23.364762Z e19f7e4 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

github-actions Bot commented Aug 30, 2026

Copy link
Copy Markdown

L9 Audit Harness Report

  • Generated: 2026-08-30T19:25:04.870512+00:00
  • Repo root: /home/runner/work/Cognitive.Engine.Graphs/Cognitive.Engine.Graphs
  • Overall result: ✅ PASSED
  • Exit code: 0

Step Results

Step Status Exit Code Notes
Architecture Audit ✅ Passed 0
Spec Coverage ✅ Passed 0
Contract Wiring ✅ Passed 0

Architecture Audit Findings

Severity Count
🔴 CRITICAL 0
🟠 HIGH 0
🟡 MEDIUM 15
🔵 LOW 0

See artifacts/audit_report.md for full details.

Spec Coverage

  • ✅ Implemented: 37
  • ⚠️ Partial: 9
  • ❌ Missing: 0
  • Total features: 46
Category Implemented Partial Missing Total
gates 10 0 0 10
scoring 7 0 0 7
v1.1_node 2 0 0 2
v1.1_edge 2 0 0 2
v1.1_action 0 2 0 2
v1.1_scoring 1 1 0 2
action_handler 0 6 0 6
gds_algorithm 5 0 0 5
research_pattern 10 0 0 10

See artifacts/coverage_report.md for full details.

Next Steps

All checks passed. Safe to merge.

cryptoxdog and others added 2 commits August 30, 2026 15:03
Issue-Remediation-Cycle: #138/cycle-1
Co-authored-by: Cursor <cursoragent@cursor.com>
Issue-Remediation-Cycle: #139/cycle-1
Co-authored-by: Cursor <cursoragent@cursor.com>

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e19f7e4251

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread engine/packet/chassis_contract.py
Comment thread engine/packet/chassis_contract.py
cryptoxdog and others added 3 commits August 30, 2026 15:14
Declaration-site factory tests no longer name PacketEnvelope so the
baseline ratchet ledger is empty. Fixes #138.

Issue-Remediation-Cycle: #138/cycle-2
Co-authored-by: Cursor <cursoragent@cursor.com>
Issue-Remediation-Cycle: #138/cycle-2
Co-authored-by: Cursor <cursoragent@cursor.com>
Chassis ingress now uses TransportPacket. The leftover PacketEnvelope module remains on disk for schema tests but is not a production import.

Remediation-Cycle: #248/cycle-2
Co-authored-by: Cursor <cursoragent@cursor.com>
@sonarqubecloud

Copy link
Copy Markdown

@cryptoxdog
cryptoxdog merged commit 514ae6c into main Aug 30, 2026
57 checks passed
@cryptoxdog
cryptoxdog deleted the agent/cursor/ceg-138-transport-packet branch August 30, 2026 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant