ci(review): add L9 Copilot code-review instructions + org rollout handoff#4
Merged
Merged
Conversation
…doff Adds the LLM reviewer layer as code, complementary to (not overlapping) the deterministic tools: - .github/copilot-instructions.md: L9-tuned Copilot code-review instructions. Explicit anti-overlap (ruff owns style/imports, CodeQL security-and-quality owns unused/dead code + security, mypy owns types) so the two reviewers don't talk over each other; focuses Copilot on logic/edge-cases/fail-closed/tests and surfaces L9 house rules (Quantum-L9 org invariant, L9_META/DORA headers, no print/eval, honest PASS/FAIL). Suggestions only; a human commits. - docs/handoffs/COPILOT_REVIEW_ROLLOUT_HANDOFF.md: GMP-format handoff to copy the instructions file to every Quantum-L9 repo and apply an org-wide ruleset that auto-requests Copilot review on PR open/update (UI click-path + as-code JSON template with a verify-the-key caveat). Guardrail: instructions are advisory LLM nudges, not enforcement — hard invariants stay in deterministic gates (validate_org_invariants.py, coding-kernel CI). Separate PR from the CodeQL centralization work, branched off main. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Rr6wpk9eehnJdRmh5BwWGG
This was referenced Jul 5, 2026
Rewrite the review focus from hand-picked rules to the repo's actual rules/*.mdc SSOT, with rule-id citations so each guideline traces back to the law: - explicit failure semantics / fail-loud + timeouts (00-global, 20-lang-python, 60-anti-patterns) - determinism & idempotency, structured audit logging (00-global) - async correctness — no blocking calls in async (20-lang-python) - existing-code-is-source-of-truth (91), tests use real drivers (50-qa-testing) - hard flags: protected core (90), secrets/env/PII (61/96/74), L9 three-block DORA header (25), graph-layer boundary (97), org invariant, honesty hard-bans Keeps the anti-overlap discipline (ruff/CodeQL/mypy own their domains) and the suggestion-only / no-auto-commit guardrail (99-no-auto-commit, 01-git-push-prohibition). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Rr6wpk9eehnJdRmh5BwWGG
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the LLM reviewer layer (Copilot code review) as code, org-wide, auto-run on PR open/update — complementary to, and explicitly non-overlapping with, the deterministic tools (ruff, CodeQL
security-and-quality, mypy). Separate PR from the CodeQL centralization work (#3), branched offmain.What's in this PR
.github/copilot-instructions.mdL9_META/DORAheaders, noprint/eval, honest PASS/FAIL). Also the canonical template to copy to every repo.docs/handoffs/COPILOT_REVIEW_ROLLOUT_HANDOFF.mdDesign notes (honest)
L9-Ops-MCP/scripts/validate_org_invariants.py, coding-kernel CI). The file references invariants; it is not load-bearing for them..github/copilot-instructions.mdis read from the repo being reviewed — not inherited from a central repo — so "org-wide" = template + per-repo copy (handoff covers it), same shape as the CodeQL caller rollout.Prerequisite / verification
L9_META). Not claimed working until that's observed.Related, not in this PR
ORG_INVARIANTS.yaml's canonical home to Cursor-Governance (separate migration; touches L9-Ops-MCP's gate) — offered as a follow-up.🤖 Generated with Claude Code
https://claude.ai/code/session_01Rr6wpk9eehnJdRmh5BwWGG
Generated by Claude Code