fix(multisig): reserve one codec depth for execute's boxed call - #676
Merged
Conversation
propose accepted inner calls at MAX_EXTRINSIC_DEPTH, but execute wraps that call in Box<RuntimeCall>. FRAME decodes the whole extrinsic at the same ceiling, so a boundary proposal could not be submitted as execute. Drop the stored-call limit by one and pin the acceptance/rejection boundary with an encode-and-decode test.
n13
force-pushed
the
n13/multisig-execute-decode-depth
branch
from
August 30, 2026 13:10
9f639d4 to
436a816
Compare
illuzen
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Multisig::executenow carries the inner call (Box<RuntimeCall>).proposestill decoded stored calls atMAX_EXTRINSIC_DEPTH. Executive decodes the complete execute extrinsic at that same ceiling, so a proposal accepted at the boundary could not be encoded as a validexecute.This is not in public
main(no inner depth cap) and not in chain-privatemain(execute did not carry the call, so the full ceiling was correct). It only appears on the merge of those two. Kept off #675 so that PR stays the merge.Change
MAX_MULTISIG_CALL_DEPTH = MAX_EXTRINSIC_DEPTH - 1proposal_depth_boundary_remains_executable: a call at the new ceiling proposes, encodes asexecute, and decodes underMAX_EXTRINSIC_DEPTH; one level deeper is rejected at proposeVerification
SKIP_WASM_BUILD=1 cargo test --locked -p pallet-multisig --lib— 61 passed