fix(runtime): charge two inner-call walks on Multisig::execute - #677
Merged
Conversation
weight() and validate() both traverse the resubmitted call, but a no-transfer execute reserved zero extension weight. A failing non-signer execute then refunded the pallet to one storage read, so broad/deep remark trees were free work against block capacity. Reserve two worst-case MaxCallSize walks for every execute and keep that reservation on early errors.
n13
force-pushed
the
n13/execute-walk-weight
branch
from
August 30, 2026 13:10
a650cb3 to
112d861
Compare
n13
changed the base branch from
n13/merge-chain-private
to
n13/multisig-execute-decode-depth
August 30, 2026 13:10
illuzen
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
WormholeProofRecorderExtension::weight()andvalidate()both walkMultisig::execute's inner call, but a no-transfer execute reserved zero extension weight. A non-signer/missing-proposal execute then refunds pallet weight to one DB read, so repeated failing executes carrying large no-transfer trees consumed two caller-controlled traversals while returning that work to block capacity.Public never charged this (execute is just another wrapper). Private charged two storage walks for opaque-id execute; that reservation was dropped when the merge adopted call-carrying execute. Neither
mainhas the call-carrying version of this fix. Kept off #675 so that PR stays the merge.Change
Multisig::executereserves two worst-case inner-call walks (MaxCallSizedecode compute, no extra PoV — the call is already in the extrinsic).post_dispatchstill refunds unused transfer reservation on error; the walk reservation is retained because that work already ran.Verification
SKIP_WASM_BUILD=1 cargo test --locked -p quantus-runtime --lib— 68 passed