fix: hide local notifications from lock screen (L14) - #589
Merged
Conversation
Set NotificationVisibility.secret on the single AndroidNotificationDetails construction site so notifications carrying transaction amounts/addresses reveal nothing on a secure lock screen, regardless of the device's global lock-screen content setting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sets
visibility: NotificationVisibility.secreton the singleAndroidNotificationDetailsconstruction site inLocalNotificationsService._notificationDetails()(covers both immediate and scheduled notifications, including FCM-foreground pushes routed through the same path)..secrethides the notification entirely on a secure lock screen, enforced at the notification level regardless of the device's global lock-screen content setting. (.private— as in #578 — is a no-op: it equals the builder default, and its redaction only applies when the user's global setting already hides sensitive content.)iOS lock-screen previews remain a per-user system setting that apps cannot control.
Addresses finding L14 of the 2026-07-22 mobile wallet security audit. Supersedes #578.