Use Geist with tabular figures for standalone numerals - #48
Merged
Conversation
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Removes the glitch effect, which depended on fixed-pitch character widths, and replaces duplicate element ids with a data-ticker attribute. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
n13
approved these changes
Sep 8, 2026
n13
left a comment
Contributor
There was a problem hiding this comment.
Reviewer model: GPT 5.6 Sol
APPROVE — no blocking findings.
The four standalone numeric styles consistently switch from Geist Mono to Geist with tabular figures. The ticker refactor preserves both marquee copies, updates both live values through non-duplicated data-ticker selectors, splits the mainnet label/value across all nine locales, and fully removes the obsolete glitch loop.
Validation:
git diff --check 9f713187...fbbad3b: passednpx --yes bun test: 22 passed, 0 failednpx --yes bun run build: passed; 1,444 pages built- Locale parity: 629 leaf keys across all 9 locales; generated EN/JA/ZH ticker attributes and bundled live-value selectors verified
npx --yes bun run format:check: remains non-clean on formatter-only drift in 27 files; no correctness issue found in the reported changed files
GitHub reports no automated checks for this head. Local focused validation found no blocking issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standalone numerals now render in Geist with tabular figures,
matching the ruling already in use in the mobile app. Mono
stays for addresses and uppercase labels, and remains the
default for protocol data such as hashes and checkphrases.
The two commits are causally linked. The mainnet ticker item
was a single fused string, so both halves were mono and the
inconsistency was invisible; it only surfaced as a bug once
.t-val changed font. Note also that .t-val lives in a
deliberate <style is:global> block, since the JS-generated
ticker elements carry no scope attribute.
Commits
four CSS declarations:
.t-val,.cell-num,.tech-stat-num,.launch-stat-value.item was a single fused string, so its date could not follow
the rule. Split into label and value like its siblings across
all nine locales. Removed the glitch effect on that item,
which scrambled characters and depended on fixed-pitch
widths. Replaced duplicate element ids with a
data-tickerattribute.
Locale keys 628 -> 629, exact parity across all nine.
22 tests pass.
astro buildpasses.Not in this pass
fixed-pitch
Follow-ups, both pre-existing and now more visible
MAINNET label, inherited from the combined string
.wallet-stat-numrenders 430, NIST 5 and 0 through oneclass; "NIST 5" is an algorithm label styled as a quantity
cannot localise
format:checkfails as it already does on main (CRLF vs LF).