Skip to content

Use Geist with tabular figures for standalone numerals - #48

Merged
dewabisma merged 2 commits into
Quantus-Network:mainfrom
sejhere:style/tabular-figures
Sep 8, 2026
Merged

Use Geist with tabular figures for standalone numerals#48
dewabisma merged 2 commits into
Quantus-Network:mainfrom
sejhere:style/tabular-figures

Conversation

@sejhere

@sejhere sejhere commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Standalone numerals now render in Geist with tabular figures,
matching the ruling already in use in the mobile app. Mono
stays for addresses and uppercase labels, and remains the
default for protocol data such as hashes and checkphrases.

The two commits are causally linked. The mainnet ticker item
was a single fused string, so both halves were mono and the
inconsistency was invisible; it only surfaced as a bug once
.t-val changed font. Note also that .t-val lives in a
deliberate <style is:global> block, since the JS-generated
ticker elements carry no scope attribute.

Commits

  1. Use Geist with tabular figures for standalone numerals
    four CSS declarations: .t-val, .cell-num,
    .tech-stat-num, .launch-stat-value.
  2. Split mainnet ticker item into label and value — the
    item was a single fused string, so its date could not follow
    the rule. Split into label and value like its siblings across
    all nine locales. Removed the glitch effect on that item,
    which scrambled characters and depended on fixed-pitch
    widths. Replaced duplicate element ids with a data-ticker
    attribute.

Locale keys 628 -> 629, exact parity across all nine.
22 tests pass. astro build passes.

Not in this pass

  • The qday-checker terminal, where column alignment depends on
    fixed-pitch
  • Mixed strings where the numeral is not its own element

Follow-ups, both pre-existing and now more visible

  • Six locales (de, es, hi, id, ko, ru) have an untranslated
    MAINNET label, inherited from the combined string
  • .wallet-stat-num renders 430, NIST 5 and 0 through one
    class; "NIST 5" is an algorithm label styled as a quantity
  • 99.97% is hardcoded in ticker.ts, so its decimal separator
    cannot localise

format:check fails as it already does on main (CRLF vs LF).

sejhere and others added 2 commits September 8, 2026 18:06
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Removes the glitch effect, which depended on fixed-pitch
character widths, and replaces duplicate element ids with a
data-ticker attribute.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@dewabisma
dewabisma requested a review from n13 September 8, 2026 13:47

@n13 n13 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewer model: GPT 5.6 Sol

APPROVE — no blocking findings.

The four standalone numeric styles consistently switch from Geist Mono to Geist with tabular figures. The ticker refactor preserves both marquee copies, updates both live values through non-duplicated data-ticker selectors, splits the mainnet label/value across all nine locales, and fully removes the obsolete glitch loop.

Validation:

  • git diff --check 9f713187...fbbad3b: passed
  • npx --yes bun test: 22 passed, 0 failed
  • npx --yes bun run build: passed; 1,444 pages built
  • Locale parity: 629 leaf keys across all 9 locales; generated EN/JA/ZH ticker attributes and bundled live-value selectors verified
  • npx --yes bun run format:check: remains non-clean on formatter-only drift in 27 files; no correctness issue found in the reported changed files

GitHub reports no automated checks for this head. Local focused validation found no blocking issues.

@dewabisma
dewabisma merged commit ab1f31d into Quantus-Network:main Sep 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants