Create the user profile document on signup; implement updateProvider

[Quasar-Apps-Agent]

Two related write-path gaps. Both make a Firebase-backed build unusable; one is already broken in debug today.

1. Signup created no profile document

IAuthService.signup only creates the credential. It accepts phoneNumber and role and has nowhere to put either, so a signed-up user ended up with an auth account and a session but no clients/providers document — every later profile read resolved to nothing.

AuthRepository.signup now writes the matching DTO, keyed on the auth uid, before persisting the session. Doing it in the repository rather than in FirebaseAuthService means it covers both backends, not just the Firebase path the audit called out.

On the non-atomicity. The credential and the profile are two separate writes and only a server-side transaction could make them one. The ordering is deliberate: the profile write happens first, so a failure leaves no session at all rather than a session pointing at a profile that doesn't exist — the latter would surface later as unexplained "not found" errors on every screen. The failure is returned as an error the user can act on rather than swallowed into a silent success; AuthViewModel renders exception.message verbatim, so the message is written as user-facing text. The residual case (auth account exists, profile doesn't, email is now taken so signup can't be retried) is recorded in ROADMAP.md as needing a server-side callable function.

New provider profiles set verificationStatus explicitly. ProviderDto's default is "" — PR #24 gave every DTO param a default so Firestore's object mapper can construct them — and ProviderDto.toDomain() runs that field through an unguarded VerificationStatus.valueOf(). A defaulted value would throw on the first read back. There's a test pinning this.

2. ProviderRepository.updateProvider was a hard stub

// TODO: Add updateProvider to IBackendService
Result.Error(Exception("Not implemented in backend service"))

It returned that for every input. CleanerProfileViewModel.saveProfile calls it, so cleaner profile edits always failed — in debug as well as release.

• IBackendService.updateProvider added (an upsert, mirroring updateClient), implemented on BackendServiceStub and FirebaseBackendService.
• ProviderRepository.updateProvider delegates to it and caches the response, matching ClientRepository.updateClient.
• New Provider.toDto() mapper — the inverse of the existing ProviderDto.toDomain(), with enums serialised as their name so the two round-trip.
• BackendServiceStub gained a mutable providerStore (the convention reviewStore already uses at :477) so profiles created or edited in-session are visible to later reads; searchProviders returns a snapshot of it rather than the backing list.

Tests

• AuthRepositoryTest — 6 new cases: client profile shape, provider profile shape, the verificationStatus guard, the ordering of the two writes, no session saved when the profile write fails, and the error message reaching the user. Existing cases updated for the new constructor param.
• ProviderRepositoryTest — new file: offline, full field fan-out to the backend, caching, error propagation without caching, thrown-exception wrapping.
• BackendServiceStubTest — upsert inserts and is visible to getProvider; upsert overwrites rather than duplicating; searchProviders returns a snapshot.
• MappersTest — Provider.toDto() round-trip and enum-name serialisation.

Docs

AUDIT_REPORT.md, README.md, ROADMAP.md, TECH_LEAD_REVIEW.md and IMPLEMENTATION_SUMMARY.md all listed these as open; each is reconciled, with the remaining atomicity gap stated rather than marked done.

Verification

No Android SDK in this environment, so CI (assembleDebug, allUnitTests, assembleDebugAndroidTest) is the compile signal — please treat a red run as blocking.

🤖 Generated with Claude Code

https://claude.ai/code/session_01G6LvbheYzc1mN9toTuuPR5

---

Generated by Claude Code

[Copilot]

Pull request overview

This PR closes two write-path gaps in the :data layer that prevented Firebase-backed usage: (1) signup now creates the corresponding clients/providers profile document, and (2) provider profile edits now work end-to-end via a new IBackendService.updateProvider upsert implemented for both the stub and Firebase backends.

Changes:

• Create the user profile document on signup in AuthRepository (before persisting the session), including explicit ProviderDto.verificationStatus initialization to avoid mapper crashes.
• Add and implement IBackendService.updateProvider across backends and wire ProviderRepository.updateProvider to delegate + cache like the client path.
• Add/extend unit tests around signup/profile creation, provider upsert/caching, backend stub behavior, and mapper round-trips; reconcile docs to mark the gaps resolved (while calling out remaining non-atomicity).

Reviewed changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
data/src/main/java/com/example/diamonds/data/repository/AuthRepository.kt	Writes the matching profile doc on successful signup (client/provider) before saving the session; wraps profile-write failures into a user-facing error.
data/src/main/java/com/example/diamonds/data/remote/backend/IBackendService.kt	Adds updateProvider(provider: ProviderDto) contract (upsert) mirroring updateClient.
data/src/main/java/com/example/diamonds/data/remote/backend/FirebaseBackendService.kt	Implements updateProvider via Firestore set(...) on providers collection.
data/src/main/java/com/example/diamonds/data/remote/backend/BackendServiceStub.kt	Adds mutable providerStore and implements provider upsert + snapshot searchProviders.
data/src/main/java/com/example/diamonds/data/repository/ProviderRepository.kt	Replaces hard-stubbed updateProvider with real backend delegation + local cache upsert.
data/src/main/java/com/example/diamonds/data/mapper/Mappers.kt	Adds Provider.toDto() mapper (inverse of ProviderDto.toDomain()).
data/src/main/java/com/example/diamonds/data/remote/auth/FirebaseAuthService.kt	Documents that signup only creates the auth credential; profile persistence happens in AuthRepository.
app/src/main/java/com/example/diamonds/di/Modules.kt	Wires IBackendService into AuthRepository via Hilt.
data/src/test/java/com/example/diamonds/data/repository/AuthRepositoryTest.kt	Adds signup tests covering client/provider doc creation, verification status, ordering, and error reporting.
data/src/test/java/com/example/diamonds/data/repository/ProviderRepositoryTest.kt	New tests for offline handling, field fan-out, caching, and error propagation/wrapping in updateProvider.
data/src/test/java/com/example/diamonds/data/remote/backend/BackendServiceStubTest.kt	Adds tests for provider upsert visibility, overwrite semantics, and snapshot search behavior.
data/src/test/java/com/example/diamonds/data/mapper/MappersTest.kt	Adds Provider.toDto() round-trip and enum-serialization tests.
TECH_LEAD_REVIEW.md	Updates findings/status to reflect updateProvider and signup profile-doc creation as addressed.
ROADMAP.md	Marks fixed items and explicitly records remaining non-atomic signup-write gap.
README.md	Marks updateProvider as resolved in the known-issues table.
IMPLEMENTATION_SUMMARY.md	Reconciles “signup creates no profile doc” to resolved (with non-atomicity caveat).
AUDIT_REPORT.md	Marks provider update and signup profile-doc issues as resolved (with remaining non-atomicity noted).

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.