refactor: consolidate rxjs imports to single entry point - #141
Merged
Conversation
🦋 Changeset detectedLatest commit: 6a765a4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the project’s RxJS usage to import pipeable operators from the single rxjs entry point, and updates the demo/docs import maps accordingly to remove rxjs/operators.
Changes:
- Replace
rxjs/operatorsimports across source + tests withfrom 'rxjs'named imports. - Remove
rxjs/operatorsfrom Vite external/import-map dependency handling. - Update README + demo import maps to RxJS
7.8.2and drop therxjs/operatorsmapping.
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| vite.demo.config.ts | Removes rxjs/operators from the import-map externalization set for the demo build. |
| vite.config.ts | Drops rxjs/operators from library build externals/globals. |
| src/navigation/novice-navigation.ts | Consolidates RxJS operator imports into rxjs. |
| src/navigation/navigation.ts | Consolidates RxJS operator imports into rxjs. |
| src/navigation/navigation.test.ts | Consolidates RxJS operator imports (incl. deprecated multicasting operator) into rxjs. |
| src/navigation/expert-navigation.ts | Consolidates RxJS operator imports into rxjs. |
| src/move/long-move.ts | Consolidates RxJS operator imports into rxjs. |
| src/move/linear-drag.ts | Moves pipeable operators into the existing rxjs import block. |
| src/move/linear-drag.test.ts | Consolidates RxJS operator imports into rxjs. |
| src/move/dwelling.ts | Consolidates RxJS operator imports into rxjs. |
| src/move/draw.ts | Consolidates RxJS operator imports into rxjs. |
| src/marking-menu.ts | Consolidates RxJS operator imports into rxjs. |
| src/marking-menu.test.ts | Consolidates RxJS operator imports into rxjs. |
| src/layout/connect.ts | Consolidates RxJS operator imports into rxjs. |
| README.md | Updates the import-map example to RxJS 7.8.2 and removes rxjs/operators. |
| demo/index.html | Updates the demo import map to RxJS 7.8.2 and removes rxjs/operators. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop
rxjs/operatorsimport map entries and consolidate all source imports tofrom 'rxjs'.rxjsentry pointrxjs/operators