Skip to content

feat(theme): ThemeLoadResult sealed types (#104) - #135

Merged
ZhuchkaTriplesix merged 2 commits into
devfrom
issue/104-theme-load-result
Jun 13, 2026
Merged

feat(theme): ThemeLoadResult sealed types (#104)#135
ZhuchkaTriplesix merged 2 commits into
devfrom
issue/104-theme-load-result

Conversation

@ZhuchkaTriplesix

Copy link
Copy Markdown
Member

Summary

  • Add ThemeLoadResult / ThemeLoadSuccess / ThemeLoadFailure for non-throwing theme load flows.
  • Include ThemeDefinition model (needed by result types; full test coverage in TP-10 — Add ThemeDefinition #105).
  • Add basic result/pattern-matching tests.

Test plan

  • flutter test test/core/theme/theme_load_result_test.dart

Closes #104

Lightweight theme descriptor required by ThemeLoadResult and upcoming registry
APIs (#105 will add dedicated tests).
Introduce success/failure results for theme loading without throwing through
UI/startup code paths. Closes #104.
@github-actions github-actions Bot added theme Theming, colors, VS Code themes error-handling Theme parser epic label: error-handling parser Theme parser epic label: parser labels Jun 13, 2026
@github-actions github-actions Bot added this to the Theme system milestone Jun 13, 2026

@ZhuchkaTriplesix ZhuchkaTriplesix left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

123

@ZhuchkaTriplesix
ZhuchkaTriplesix merged commit 30db7f5 into dev Jun 13, 2026
3 checks passed
@ZhuchkaTriplesix
ZhuchkaTriplesix deleted the issue/104-theme-load-result branch June 15, 2026 04:13
ZhuchkaTriplesix added a commit that referenced this pull request Jul 27, 2026
feat(theme): ThemeLoadResult sealed types (#104)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

error-handling Theme parser epic label: error-handling parser Theme parser epic label: parser theme Theming, colors, VS Code themes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant