Skip to content

TP-28: Performance test for 50+ themes in picker - #154

Merged
ZhuchkaTriplesix merged 1 commit into
devfrom
issue/123-performance-50-themes-picker
Jun 14, 2026
Merged

TP-28: Performance test for 50+ themes in picker#154
ZhuchkaTriplesix merged 1 commit into
devfrom
issue/123-performance-50-themes-picker

Conversation

@ZhuchkaTriplesix

Copy link
Copy Markdown
Member

Summary

  • Add ThemePickerButton large list widget tests with 60 fake ThemeDefinition entries.
  • Assert ListView.builder is used (childCount: 60), only a visible subset of rows is built initially, and the last theme can be selected without overflow.

Test plan

  • flutter test test/features/settings/theme_picker_button_test.dart
  • Manual: open Preferences theme picker with many installed themes — scroll/search stays responsive, no overflow

Closes #123

@github-actions github-actions Bot added theme Theming, colors, VS Code themes performance Theme parser epic label: performance tests Theme parser epic labels Jun 14, 2026
@github-actions github-actions Bot added this to the Theme system milestone Jun 14, 2026

@ZhuchkaTriplesix ZhuchkaTriplesix left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

123

@ZhuchkaTriplesix
ZhuchkaTriplesix merged commit eb424a5 into dev Jun 14, 2026
4 checks passed
@ZhuchkaTriplesix
ZhuchkaTriplesix deleted the issue/123-performance-50-themes-picker branch June 15, 2026 04:13
ZhuchkaTriplesix added a commit that referenced this pull request Jul 27, 2026
…s-picker

TP-28: Performance test for 50+ themes in picker
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

performance Theme parser epic label: performance tests Theme parser epic theme Theming, colors, VS Code themes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant