fix(connections): improve PostgreSQL connection UX and error typing - #263
Merged
Merged
Conversation
github-actions
Bot
added
bug
…255, #256, #259) - Extract host and port from the connection URI so URI-only PostgreSQL rows show meaningful metadata in the sidebar. - Throw PostgresConnectionException from connect() with original cause and stack trace preserved. - Wrap unexpected factory failures in PostgresConnectionPool.acquire and rethrow typed PostgreSQL exceptions unchanged. - Update tests for exception fields, typed connect errors, pool wrapping, and URI-derived display metadata.
ZhuchkaTriplesix
force-pushed
the
issue/255-256-259-postgres-connection-ux
branch
from
July 10, 2026 09:01
c840b63 to
5b86b2e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #255
Closes #256
Closes #259
Summary
Follow-up P2 fixes for PostgreSQL connection handling: keep display metadata for URI-only rows, type connection errors, and make the pool wrap factory failures consistently.
Changes
hostandportfrom the PostgreSQL URI so the connection tree shows meaningful info for URI-only rows.connect()now throwsPostgresConnectionExceptionwith the original cause and stack trace preserved.PostgresConnectionPool.acquirerethrowsPostgresConnectionExceptionunchanged and wraps unexpected factory errors in the same typed exception.Test plan
flutter test test/core/database/postgres_connection_test.dartflutter test test/core/database/postgres_connection_pool_test.dartflutter test test/features/postgresql/postgresql_connection_form_test.dart