fix(mysql): harden custom SELECT validation in table browser (#274) - #288
Merged
Conversation
Tokenize SQL outside string literals and comments before splitting on semicolons so valid queries with ';' in literals are not blocked. Reject INTO OUTFILE, FOR UPDATE, and other write-side constructs when they appear outside masked literals/comments.
github-actions
Bot
added
bug
3 tasks
ZhuchkaTriplesix
added a commit
that referenced
this pull request
Jul 27, 2026
fix(mysql): harden custom SELECT validation in table browser (#274)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isAllowedMysqlSelectQueryto split statements only on semicolons outside string literals, quoted identifiers, and comments (--,#,/* */).INTO OUTFILE,FOR UPDATE, DML/DDL keywords) when they appear outside masked literals/comments.Fixes #274.
Test plan
flutter test test/features/mysql/mysql_table_utils_test.dartSELECT * FROM t WHERE col = 'a;b'— should executeSELECT 1; SELECT 2andSELECT * INTO OUTFILE ...are rejected