fix(core): log swallowed errors in connection drivers and folders storage (#272) - #289
Merged
Merged
Conversation
…rage (#272) Replace silent catch (_) {} blocks with debugPrint so disconnect failures, stats probe errors, and folder load/migration issues are visible in logs.
github-actions
Bot
added
bug
ZhuchkaTriplesix
added a commit
that referenced
this pull request
Jul 27, 2026
fix(core): log swallowed errors in connection drivers and folders storage (#272)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
catch (_) {}in Postgres/MySQL/SQLite/RedisdisconnectandforceClosewithdebugPrintso close failures are visible in logs.pg_postmaster_start_time,pg_database_size) instead of returning partial stats silently.FoldersStorage.loadand legacy migration errors instead of swallowing them.Fixes #272.
Test plan
flutter test test/core/database/postgres_connection_test.dart test/core/database/mysql_connection_test.dart test/core/database/sqlite_connection_test.dart test/core/database/redis_connection_test.dartdebugPrintoutput appears in console/log