Skip to content

fix(ui): global File menu SQL intents outside SQL workspace - #297

Merged
ZhuchkaTriplesix merged 2 commits into
devfrom
issue/268-sql-file-menu-global
Jul 10, 2026
Merged

fix(ui): global File menu SQL intents outside SQL workspace#297
ZhuchkaTriplesix merged 2 commits into
devfrom
issue/268-sql-file-menu-global

Conversation

@ZhuchkaTriplesix

Copy link
Copy Markdown
Member

Summary

  • Add SqlEditorGlobalActions fallback at MainScreen so File → New/Open/Save works from the title bar and non-SQL views (table view, MongoDB, Redis, empty workspace).
  • Introduce SqlEditorCommandBridge so mounted SQL workspaces handle commands when menu focus is outside the editor subtree.
  • Open the SQL workspace (or show a SnackBar hint) when no SQL editor is active.

Fixes #268

Test plan

  • flutter test test/core/actions/
  • File → New with PostgreSQL connection on table view opens SQL tab and clears editor
  • File → Open/Save with Redis/Mongo active shows hint SnackBar
  • File → New while SQL tab is open still clears editor via bridge

Ensures New/Open/Save work from the title bar and non-SQL views by
opening the SQL workspace or showing a hint when no SQL connection is active.

Fixes #268
@github-actions github-actions Bot added bug Something isn't working editor Code/SQL editor ui User interface components and widgets labels Jul 10, 2026
Fixes prefer_const_constructors analyzer warnings in CI.
@ZhuchkaTriplesix
ZhuchkaTriplesix merged commit 66eed1f into dev Jul 10, 2026
4 checks passed
@ZhuchkaTriplesix ZhuchkaTriplesix self-assigned this Jul 12, 2026
@ZhuchkaTriplesix
ZhuchkaTriplesix deleted the issue/268-sql-file-menu-global branch July 26, 2026 14:39
ZhuchkaTriplesix added a commit that referenced this pull request Jul 27, 2026
fix(ui): global File menu SQL intents outside SQL workspace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working editor Code/SQL editor ui User interface components and widgets

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant