Skip to content

fix(ui): synchronize column width recalculation in VirtualResultGrid (#331) #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ZhuchkaTriplesix merged 1 commit into from
Jul 12, 2026
Merged

fix(ui): synchronize column width recalculation in VirtualResultGrid (#331) #335

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions lib/features/main_screen/result_grid_view.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,10 +63,7 @@ class _VirtualResultGridState extends material.State<VirtualResultGrid> {
@override
void didChangeDependencies() {
super.didChangeDependencies();
if (_widthsNeedUpdate) {
_columnWidths = _computeColumnWidths();
_widthsNeedUpdate = false;
}
_widthsNeedUpdate = true;
}

@override
Expand Down Expand Up @@ -106,6 +103,10 @@ class _VirtualResultGridState extends material.State<VirtualResultGrid> {

@override
material.Widget build(material.BuildContext context) {
if (_widthsNeedUpdate) {
_columnWidths = _computeColumnWidths();
_widthsNeedUpdate = false;
}
final cs = Theme.of(context).colorScheme;
final colCount = widget.columns.length;
final rowHeight = _scaledRowHeight(context);
Expand Down
41 changes: 41 additions & 0 deletions test/features/main_screen/results_tab_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,5 +97,46 @@ void main() {
tester.widgetList(find.byType(material.Row)).length;
expect(dataRowWidgets, lessThan(80));
});

testWidgets(
'recalculates column widths when updated with different columns without throwing RangeError',
(tester) async {
await tester.pumpWidget(
queryaThemeTestShell(
child: const material.SizedBox(
height: 400,
width: 600,
child: VirtualResultGrid(
columns: ['id', 'name'],
rows: [
['1', 'Alpha'],
],
),
),
),
);
await tester.pumpAndSettle();

// Now update the grid with 5 columns instead of 2
await tester.pumpWidget(
queryaThemeTestShell(
child: const material.SizedBox(
height: 400,
width: 600,
child: VirtualResultGrid(
columns: ['id', 'name', 'email', 'status', 'created_at'],
rows: [
['1', 'Alpha', 'alpha@example.com', 'active', '2026-07-13'],
],
),
),
),
);
await tester.pumpAndSettle();

expect(tester.takeException(), isNull);
expect(find.text('email'), findsOneWidget);
expect(find.text('created_at'), findsOneWidget);
});
});
}
Loading