fix(sandbox): require consent before unsandboxed driver launch - #409
Merged
Conversation
Closes #395 — fail-closed when OS sandbox wrapper unavailable; user must confirm via dialog on Linux (no bwrap) and Windows until AppContainer.
github-actions
Bot
added
enhancement
Windows platformOverride in unit tests simulates soft isolation; consent flag is required after #395 fail-closed behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
allowUnsandboxedLaunchonly after user approvaldocs/security.mdCloses #395
Test plan
flutter test test/core/extensions/sandbox/sandbox_os_isolation_test.dartflutter test test/core/extensions/sandbox/sandbox_process_runner_test.dartflutter test test/core/extensions/sandbox/