perf(marketplace): stream SHA256 + file-stream zip decode (#418) - #433
Merged
Conversation
Hash archives with sha256HexOfFile (openRead stream) and decode via InputFileStream so marketplace/sideload no longer keep a full byte buffer plus ZipDecoder output. Clear entry content after write. Closes #418
github-actions
Bot
added
performance
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sha256HexOfFile/openRead(same as updater) — nosha256.convert(fullBytes)SafeZipExtractor.readAndDecodeFileusesInputFileStream+ZipDecoder.decodeStreamArchiveFilecontent after each writedocs/security.mdCloses #418
Parent: #414
Test plan
flutter test test/core/security/safe_zip_extractor_test.dart test/core/extensions/local_extension_installer_test.dart test/core/market/marketplace_repository_test.dart.zipwith optional checksum; marketplace install mock path