fix(core): resolve latent bugs in grid filtering, MySQL escaping, export formatters, and staging buffer disposal - #699
Merged
Conversation
…ort formatters, and staging buffer disposal (#698)
This was referenced Sep 6, 2026
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #698
Summary of Changes
Row Filtering Bypassed in Grid with StagingBuffer & Mutation Index Collision:
rowIndicesMappingtoVirtualResultGrid.ResultsTab, cached filtered indices and passed them toVirtualResultGrid.VirtualResultGridrendersrowswhenrowIndicesMappingis present, while mapping visual sorted rows back to underlying buffer row indices via_toModelRowIndex._openInspector,toggleDeleteRow, andrevertRowshortcut handlers to route through_toModelRowIndex.SQL Syntax Error / Escape Issue with Backslashes in MySQL DML Generation:
TableMutationEngine, strings forSqlDialect.mysqlnow escape backslashes\with\\before escaping quotes.Leading Zeros Stripping in JSON Export:
ResultGridSelection.toJson, strings with leading zeros (e.g.^0\d+$) are preserved as strings without being coerced to numbers.TSV Export / Copy Delimiter Corruption on Newlines & Tabs:
ResultGridSelection.toTsv, values containing\t,\n,\r, or"are now escaped with enclosing quotes and double quotes per standard TSV escaping.StagingBuffer Memory Leak on Query Tab Close:
SqlQueryTabSession.dispose, explicitly callsstagingBuffer?.dispose().Verification
flutter analyze: 0 issues found.