Nimble.xcodeproj: Lower iOS deployment target to 7.0#118
Merged
Conversation
Member
|
👍 |
jeffh
added a commit
that referenced
this pull request
Apr 6, 2015
Nimble.xcodeproj: Lower iOS deployment target to 7.0
Member
|
Merged. Pushed v0.4.2. Thanks! |
phatblat
pushed a commit
to phatblat/Nimble
that referenced
this pull request
May 3, 2020
Added Moya to list of users
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick and Nimble can be used to test code running against on iOS 7.0, but their deployment targets were set too high in order to do so. Lower Nimble's deployment target to make this possible.
Unfortunately, a warning is generated during the linking phase for Nimble-iOS: "ld: warning: embedded dylibs/frameworks only run on iOS 8 or later". I'm not sure if this is avoidable. I'm no expert, though, I just skimmed ReactiveCocoa/ReactiveCocoa#1480.
A new release should be made after merging these changes.