Skip to content

Replace deprecated libswiftXCTest.dylib with libXCTestSwiftSupport.dylib#863

Merged
ikesyo merged 2 commits intoQuick:masterfrom
trailbehind:ec/fix/xcode-12.5-bug
Mar 3, 2021
Merged

Replace deprecated libswiftXCTest.dylib with libXCTestSwiftSupport.dylib#863
ikesyo merged 2 commits intoQuick:masterfrom
trailbehind:ec/fix/xcode-12.5-bug

Conversation

@evelynccordner
Copy link

@evelynccordner evelynccordner commented Feb 18, 2021

Addresses #855 so that Nimble will compile with xcode beta 12.5.

@evelynccordner evelynccordner deleted the ec/fix/xcode-12.5-bug branch February 18, 2021 17:39
@evelynccordner evelynccordner restored the ec/fix/xcode-12.5-bug branch February 18, 2021 17:39
@CraigSiemens CraigSiemens mentioned this pull request Mar 1, 2021
Closed
1 task
@evelynccordner evelynccordner reopened this Mar 1, 2021
ikesyo
ikesyo requested changes Mar 2, 2021
View reviewed changes
Copy link
Member

@ikesyo ikesyo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please update the remaining references as well?

@evelynccordner evelynccordner requested a review from ikesyo March 2, 2021 14:13
ikesyo
ikesyo approved these changes Mar 3, 2021
View reviewed changes
Copy link
Member

@ikesyo ikesyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the pull request! 👍

@ikesyo ikesyo merged commit 57ed10e into Quick:master Mar 3, 2021
@freak4pc
Copy link

freak4pc commented Apr 22, 2021

Any chance to get a release with this? Xcode 12.5 RC 1 was out yesterday and this is blocking our test builds @ikesyo 🙏

@ikesyo
Copy link
Member

ikesyo commented Apr 24, 2021 •
edited
Loading

v9.0.1 has been released, thanks for your patience!

rawbee added a commit to underdog-tech/pinwheel-ios-sdk that referenced this pull request May 5, 2021
@rawbee
Bump nimble version to pick up [build fix](Quick/Nimble#863)
c20c8f4
@rawbee rawbee mentioned this pull request May 5, 2021
Merged
10 tasks
rawbee added a commit to underdog-tech/pinwheel-ios-sdk that referenced this pull request May 5, 2021
@rawbee
Bump nimble version to pick up [build fix](Quick/Nimble#863) (#22)
3a2818b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ikesyo ikesyo ikesyo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@evelynccordner @freak4pc @ikesyo