Add toAlways, the inverse of toNever.#969
Merged
younata merged 1 commit intoQuick:mainfrom Apr 16, 2022
Merged
Conversation
jessesquires
approved these changes
Apr 15, 2022
Document toAlways and toNever
3dcfeca to
b34f36e
Compare
Member
|
Rebasing this to re-run CI |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
toNeverwas added somewhat recently, where we verify that a matcher continues to fail until the timeout happens. It felt odd to me that there wasn't a way to verify that a watcher continues to succeed until the timeout happens. So I addedtoAlwaysto capture that.This adjusts how the private
asyncfunction works, to also take in the behavior that we want the predicate to always match. I briefly looked into consolidatingAsyncMatchStyle.neverandAsyncMatchStyle.alwaysbecause they are very similar, but decided against DRY'ing that up because it would unnecessarily add complexity.This also adds documentation in the README around how to use
toNeverandtoAlways. It's not great documentation, but I hope this gets the idea across.