fix(setup-cert): keep SHA-1 retry compatible with LibreSSL - #22
Merged
QuiteYellow merged 1 commit intoAug 3, 2026
Merged
Conversation
Contributor
Author
|
@codex review |
This was referenced Aug 2, 2026
Jason-Morcos
marked this pull request as ready for review
August 2, 2026 21:52
Contributor
Author
|
Adversarial re-review complete for exact head Validation remains 38 passed with LibreSSL 3.3.6 and OpenSSL 3.6.3, plus 5 focused signing tests on each CLI. @codex review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
setup_cert.pyretries a rejected SHA-1 signing command with an OpenSSL 3 provider configuration. Apple's/usr/bin/opensslis LibreSSL, not OpenSSL 3; LibreSSL can exit successfully after reading that incompatible configuration without executingopenssl x509. The script then reachesclient.pemwith no certificate present, masking the original signing failure with a laterFileNotFoundError.This also makes the existing SHA-1 retry test fail on a clean macOS checkout.
Root cause
run_allow_sha1()assumed every executable namedopensslunderstands OpenSSL 3's provider configuration.Fix
openssl versionbefore selecting the retry environment.OPENSSL_CONF.Scope and compatibility
This does not change the generated key, certificate fields, chain, SHA-1 requirement, or any network behavior. Existing OpenSSL 3 behavior is preserved. No certificate or key material is added to the repository.
Validation
38 passed38 passed5 passed