feat(ci): expand code owner pool for packages/core - #8347
Merged
Conversation
Collaborator
wenshao
force-pushed
the
feat/core-review-router
branch
from
August 2, 2026 01:04
a8b0510 to
f33bd96
Compare
Contributor
|
Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. 中文请勿对活跃的 PR 执行 rebase 或 force-push，因为这会使已有的评审评论失效。另外，供日后参考：作为集成流程的一部分，机器人始终会自动将所有改动压缩（squash）为单个提交。 |
Collaborator
|
Thanks for the PR! Template looks good ✓ (the "Evidence (Before & After)" subsection is absent, but N/A is the right answer for a CODEOWNERS edit — no issue there). Problem: observed operational bottleneck — maintainer PRs touching Direction: aligned. Expanding the code owner pool is a straightforward way to reduce review latency. Size: not applicable — Approach: the scope is exactly right — two line edits, nothing extraneous. No simpler path exists for this goal. Risk: no elevated risk signals. Moving on to code review. 🔍 中文说明感谢贡献！ 模板完整 ✓（"Evidence (Before & After)" 子节缺失，但对 CODEOWNERS 编辑来说 N/A 是正确答案，不算问题）。 问题：已观测到的运维瓶颈——maintainer 开 PR 改 方向：对齐。扩大 code owner 池是降低 review 延迟的直接方式。 规模：不适用—— 方案：范围恰好——两行编辑，没有多余改动。没有更简路径。 风险：无升级风险信号。 进入代码审查 🔍 — Qwen Code · qwen3.8-max-preview Reviewed at |
Collaborator
|
Code review: the diff does exactly what the description says — adds Independent proposal match: I would have done exactly this — edit the two CODEOWNERS lines to add the new reviewer and a backup owner for the file itself. The PR matches 1:1. Testing:
All checks completed — no failures. macOS/Windows tests and integration tests were skipped (expected for a CODEOWNERS-only change). Real-scenario testing: N/A — no user-visible behavioral change. 中文说明代码审查： diff 与描述完全一致——在 独立方案匹配：我的独立方案与此完全相同。 测试： 所有 CI 检查已完成，无失败。macOS/Windows 测试和集成测试被跳过（对纯 CODEOWNERS 更改属预期行为）。 真实场景测试：N/A——无用户可见行为变更。 — Qwen Code · qwen3.8-max-preview Reviewed at |
Collaborator
|
Confidence: 5/5 — clean across every stage; would merge without hesitation. This is as simple as a PR gets: two line edits to CODEOWNERS that do exactly what the description promises. The motivation is clear (reduce review blocking when maintainers are unavailable), the choice of 中文说明置信度：5/5——每个阶段都干净，毫不犹豫可以合并。 这是一个极其简单的 PR：两行 CODEOWNERS 编辑，完全符合描述。动机清晰（减少 maintainer 不在线时的 review 阻塞），选择 — Qwen Code · qwen3.8-max-preview Reviewed at |
Contributor
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-22.x-ubuntu-latest' artifact from the main CI run. |
qwen-code-ci-bot
requested changes
Aug 2, 2026
qwen-code-ci-bot
left a comment
qwen-code-ci-bot
left a comment
Collaborator
There was a problem hiding this comment.
Not linted (tool limitation, not a blocker): the executable-script lint — .github/workflows/ci.yml: actionlint embedded-shell source mapping is not yet supported — not linted; the executable-script lint — .github/workflows/core-review-router.yml: actionlint embedded-shell source mapping is not yet supported — not linted.
中文说明
未检查（工具限制，非阻断）：the executable-script lint — .github/workflows/ci.yml: actionlint embedded-shell source mapping is not yet supported — not linted; the executable-script lint — .github/workflows/core-review-router.yml: actionlint embedded-shell source mapping is not yet supported — not linted。
— qwen3.8-max-preview via Qwen Code /review
Add @doudouOUC to /packages/core/ and @wenshao to /.github/CODEOWNERS so maintainer PRs have more potential approvers available.
wenshao
force-pushed
the
feat/core-review-router
branch
from
August 2, 2026 01:44
f33bd96 to
d0adfac
Compare
wenshao
changed the title
qwen-code-ci-bot
left a comment
qwen-code-ci-bot
left a comment
Collaborator
There was a problem hiding this comment.
中文说明
— qwen3.8-max-preview via Qwen Code /review
Collaborator
Author
|
@qwen-code /triage |
Collaborator
|
Sandboxed verification: ✅ passed — merge-ready (agent verdict) - workflow run Ran the PR in an isolated, token-free container: A/B against the base build, mock-free harness assertions, targeted gates. Advisory evidence for human reviewers — not a review, an approval, or a CI check. Scripted assertions: 23 passed · 0 failed · 23 total 中文 — 判定：✅ 通过 · 可合入（agent 判定）沙箱验证在隔离、无凭证的容器中执行了该 PR 的代码（与 base 构建 A/B 对照、无 mock harness 断言、定向门禁）。仅作为评审证据，不构成评审、批准或 CI 检查。 脚本断言：23 通过 · 0 失败 · 23 总计 Verification reportPR #8347 — Deep VerificationVerdict: 中文摘要
Scope
This is a metadata-only PR: no executable code, no workflow, no script, no dependency change. There is therefore no runtime A/B in the usual sense; the correct oracle is a CODEOWNERS parser + pattern-matcher implementing GitHub's documented grammar, run identically over the real base and head artifacts. That is exactly what the harness does. Central claim + A/BThe A/B compares two artifacts through one oracle (
Load-bearing flip (the pair a reviewer actually cares about):
The full 23-row run is captured in
Positive control (the harness is not always-green)A green run on the real artifacts proves the suite passes; it does not prove the harness can fail. Three mutants of the head artifact each trip their intended assertion with a clear expected-vs-actual detail (captured in
Because reverting the very change this PR makes turns A19 red, the central assertion is genuinely load-bearing: it would have caught a PR that claimed to add CorrectionsNone. The PR description's table matches the committed diff exactly, and its prose claims check out against the file: FindingsNo blocking findings. One honest, non-blocking caveat is recorded under Not covered (handle existence on GitHub), because it is an external fact this sandbox cannot observe, not a defect in the diff. Not covered
MethodologyEnvironment: CI verify container ( Evidence images
Harness scripts and raw logs are in the workflow run artifacts (7-day retention). — Qwen Code · sandboxed verification |
qwen-code-ci-bot
approved these changes
Aug 2, 2026
qwen-code-ci-bot
left a comment
qwen-code-ci-bot
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, looks ready to ship. ✅
pomelo-nwu
approved these changes
Aug 3, 2026
Collaborator
|
Released in v0.21.4. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Expands the code owner pool to reduce blocking when a specific maintainer is unavailable:
/packages/core/@wenshao @tanzhenxin @yiliang114 @LaZzyMan@doudouOUC/.github/CODEOWNERS@pomelo-nwu@wenshaoWhy it's needed
Maintainer PRs touching
packages/core/require code owner approval (rulesetrequire_code_owner_review: true). With only 3 potential approvers (excluding the author), it's common to be blocked when all of them are offline, on leave, or away. Adding@doudouOUC— the most active non-maintainer core contributor (14 commits in the last 3 months) — gives one more person who can approve.Adding
@wenshaoto the CODEOWNERS file entry avoids a single-person bottleneck on CODEOWNERS changes themselves.Reviewer Test Plan
How to verify
@doudouOUCappears on the/packages/core/line@doudouOUCis auto-assigned as a code owner reviewerTested on
Risk & Scope
@doudouOUCgains code owner approval rights forpackages/core/.Linked Issues
Supersedes #7469. Follow-up to #7376.
中文说明
扩大 code owner 池，减少因特定 maintainer 不在线而被阻塞的概率。
@doudouOUC是近 3 个月最活跃的非 maintainer core 贡献者（14 次提交），加入后 maintainer 开 PR 时有 4 个潜在 approver 可找。同时将@wenshao加入 CODEOWNERS 文件自身的 owner 列表，避免改 CODEOWNERS 时只能等一个人。