Skip to content

feat: solid integration#2291

Closed
voluntadpear wants to merge 17 commits intoQwikDev:mainfrom
voluntadpear:qwik-solid
Closed

feat: solid integration#2291
voluntadpear wants to merge 17 commits intoQwikDev:mainfrom
voluntadpear:qwik-solid

Conversation

@voluntadpear
Copy link
Copy Markdown
Contributor

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests

Description

Qwikifying Solid.

Use cases and why

    1. One use case
    1. Another use case

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

@bolt-new-by-stackblitz
Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@gitguardian
Copy link
Copy Markdown

gitguardian Bot commented Jan 8, 2023

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id Secret Commit Filename
- Google API Key 8d5b01f packages/docs/scripts/showcase.js View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@voluntadpear voluntadpear mentioned this pull request Jan 20, 2023
@Dindaleon
Copy link
Copy Markdown

Hello, is there any ETA for this integration? I am eagerly looking forward to it.

@zanettin zanettin changed the title qwik-solid integration (WIP) feat: solid integration Feb 25, 2023
@zanettin zanettin added enhancement New feature or request DX Developer Experience related issue labels Feb 25, 2023
@gioboa
Copy link
Copy Markdown
Member

gioboa commented Aug 24, 2023

Are you still working on this feature? Do you need any help?

@gioboa
Copy link
Copy Markdown
Member

gioboa commented Oct 10, 2023

hi @voluntadpear thanks for your commitment and for this amazing piece of work.
The best option for this kind of integration is:


Have a community organization

  • Have a https://github.com/QwikDev organization that can publish to @qwikdev/____ The nice part of the org is that it still has the "seal" of Qwik without passing on the cost to the Qwik core maintainers.
  • This way, the core Qwik team is not on the hook to support the feature long time (as most of the time, they are not the experts)
  • Qwik core team is not involved in having to review the PR and make a judgment call if the quality is good enough (given that hey are not the experts in that area)

I will close this PR, thanks again for your awesome job.

@gioboa gioboa closed this Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DX Developer Experience related issue enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants