Bug style undefined #401
Merged
Bug style undefined #401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/core/render/cursor.ts
Outdated
| const handleStyle: PropHandler = (ctx, elm, _, newValue) => { | ||
| setAttribute(ctx, elm, 'style', stringifyClassOrStyle(newValue, false)); | ||
| const style = stringifyClassOrStyle(newValue, false); | ||
| if (Object.keys(style).length > 0) { |
Contributor
There was a problem hiding this comment.
I think it should be:
if (style.length > 0) {
since. its already a string.
Actually, why do we need this if statement at all, I can see a problem that styles never get removed.
Contributor
Author
There was a problem hiding this comment.
@manucorporat, yes you are right, for some reason saw that as object. My idea was to handle the case where style would be an empty string:
"style={{display: undefined}}" to "style='' ".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
This JSX: <div style={{display: undefined}}">
Results in:
Should be:
Link: (#340)