Skip to content

Conversation

@ianlet
Copy link
Contributor

@ianlet ianlet commented Sep 29, 2024

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos
  • Infra

Description

New starter command to setup Qwik Testing Library.

image

Rel. ianlet/qwik-testing-library#8

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have ran pnpm change and documented my changes
  • I have made corresponding changes to the Qwik docs
  • Added new tests to cover the fix / functionality

@ianlet ianlet requested review from a team as code owners September 29, 2024 17:58
@changeset-bot
Copy link

changeset-bot bot commented Sep 29, 2024

🦋 Changeset detected

Latest commit: 0cf4225

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
create-qwik Patch
@builder.io/qwik Patch
eslint-plugin-qwik Patch
@builder.io/qwik-city Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Sep 29, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 0cf4225

@ianlet
Copy link
Contributor Author

ianlet commented Oct 7, 2024

@thejackshelton could you have a look at this? It would be great if it could be merged for the v1.10.0 release so the CLI is ready to be used for when the official Testing Library docs gets updated.

Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're planning to move integrations into community plugins under the "QwikCommunity" org so we could share the maintenance work with community plugin maintainers.

Here is the RFC QwikDev/qwik-evolution#191 so I'm keeping this PR opened until we'll implement the plugin system

Thanks again! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants