Skip to content

Conversation

@Varixo
Copy link
Member

@Varixo Varixo commented Nov 21, 2025

Skip some unnecessary work during setting attribute for vnode diff

@Varixo Varixo self-assigned this Nov 21, 2025
@Varixo Varixo requested a review from a team as a code owner November 21, 2025 14:56
@changeset-bot
Copy link

changeset-bot bot commented Nov 21, 2025

⚠️ No Changeset found

Latest commit: be5d399

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Varixo Varixo moved this from Backlog to Waiting For Review in Qwik Development Nov 21, 2025
Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wmertens wmertens enabled auto-merge November 21, 2025 15:04
@wmertens wmertens merged commit 0bdbd8f into build/v2 Nov 21, 2025
19 checks passed
@wmertens wmertens deleted the v2-optimize-attr-diff branch November 21, 2025 15:11
@github-project-automation github-project-automation bot moved this from Waiting For Review to Done in Qwik Development Nov 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants