Skip to content

fix(dev): use vite base in click-to-component #8187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 1, 2025
+9 −6
Merged

fix(dev): use vite base in click-to-component #8187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/qwik/src/optimizer/src/plugins/dev/click-to-component.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ if (typeof document !== 'undefined') {
const register = () => {
const inspectAttribute = 'data-qwik-inspector';
const hotKeys = globalThis.__HOTKEYS__;
const srcDir = globalThis.__SRC_DIR__;
const base = globalThis.__BASE__;
let popup = document.querySelector('#qwik-inspector-info-popup');
if (!popup) {
popup = document.createElement('div');
Expand Down Expand Up @@ -92,7 +92,7 @@ if (typeof document !== 'undefined') {
const match = inspectUrl.match(/^(.*?)(:\d+(:\d+)?)?$/);
if (match) {
const [, filePath, location] = match;
fetch(`${filePath}?editor${location}`).then(() => {
fetch(`${base}${filePath}?editor${location}`).then(() => {
body.style.removeProperty('cursor');
});
}
Expand Down
9 changes: 6 additions & 3 deletions packages/qwik/src/optimizer/src/plugins/dev/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ function invalidPreviewMessage(middlewares: Connect.Server, msg: string) {
});
}

export const getViteIndexTags = (opts: NormalizedQwikPluginOptions, srcDir: string) => {
export const getViteIndexTags = (opts: NormalizedQwikPluginOptions, base: string) => {
const tags: HtmlTagDescriptor[] = [
{ tag: 'style', children: qwikErrorOverlayStyles, injectTo: 'body' },
{ tag: 'style', children: inspectorStyles, injectTo: 'body' },
Expand All @@ -104,13 +104,16 @@ export const getViteIndexTags = (opts: NormalizedQwikPluginOptions, srcDir: stri
}
if (opts.devTools?.clickToSource ?? true) {
const hotKeys = opts.devTools.clickToSource ?? [];
const srcDirUrl = new URL(srcDir + '/', 'http://local.local').href;
// the filepaths start with /
if (base.endsWith('/')) {
base = base.slice(0, -1);
}
tags.push({
tag: 'script',
attrs: { type: 'module' },
children: clickToComponent
.replace('globalThis.__HOTKEYS__', JSON.stringify(hotKeys))
.replace('globalThis.__SRC_DIR__', JSON.stringify(srcDirUrl)),
.replace('globalThis.__BASE__', JSON.stringify(base)),
injectTo: 'body',
});
}
Expand Down
2 changes: 1 addition & 1 deletion packages/qwik/src/optimizer/src/plugins/vite.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -564,7 +564,7 @@ export function qwikVite(qwikViteOpts: QwikVitePluginOptions = {}): any {
if (viteCommand !== 'serve') {
return;
}
return getViteIndexTags(qwikPlugin.getOptions(), srcDir!);
return getViteIndexTags(qwikPlugin.getOptions(), basePathname);
},
configureServer(server: ViteDevServer) {
qwikPlugin.configureServer(server);
Expand Down