fix: computed signal memory leak when reusing effect subscriber in loop #8254
+64
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: df3ed1a The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
Contributor
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Base automatically changed from
v2-fix-iteration-variable-in-qrl-prop
to
build/v2
January 22, 2026 20:42
Varixo
force-pushed
the
v2-fix-computed-memory-leak
branch
from
5c41ee2 to
e71937f
Compare
wmertens
reviewed
Jan 23, 2026
| if (ctx) { | ||
| const effectSubscriber = getSubscriber(this, EffectProperty.VNODE); | ||
| // clear existing back refs | ||
| effectSubscriber.backRef?.clear(); |
Member
There was a problem hiding this comment.
- I think the backrefs can be cleared as soon as the signal is marked dirty, because nothing else can make it dirtier
- But most importantly, when clearing backrefs, each signal must also have this subscriber removed
Varixo
force-pushed
the
v2-fix-computed-memory-leak
branch
from
e71937f to
df3ed1a
Compare
github-project-automation
bot
moved this from Waiting For Review
to Done
in Qwik Development
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clear back refs for effect subscriber when reusing in computed signal computation