Skip to content

fix(qwik-city): Link hash change does not update location.url.hash#8305

Merged
maiieul merged 2 commits intoQwikDev:mainfrom
maiieul:fix-link-nav-hash-change
Feb 6, 2026
Merged

fix(qwik-city): Link hash change does not update location.url.hash#8305
maiieul merged 2 commits intoQwikDev:mainfrom
maiieul:fix-link-nav-hash-change

Conversation

@maiieul
Copy link
Member

@maiieul maiieul commented Feb 6, 2026

What is it?

  • Bug

Description

Updating the hash with <Link href={"#new-hash"}> would not update the routeLocation.url internally, preventing the useLocation hook from tracking the changes in the location.url. This fixes the issue.

Checklist

  • My code follows the developer guidelines of this project
  • I performed a self-review of my own code
  • I added a changeset with pnpm change
  • I made corresponding changes to the Qwik docs
  • I added new tests to cover the fix / functionality

@maiieul maiieul requested a review from a team as a code owner February 6, 2026 15:18
@changeset-bot
Copy link

changeset-bot bot commented Feb 6, 2026

🦋 Changeset detected

Latest commit: 2a61ae7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@builder.io/qwik-city Patch
eslint-plugin-qwik Patch
@builder.io/qwik Patch
create-qwik Patch
@builder.io/qwik-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2026

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 2a61ae7

@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 6, 2026

Open in StackBlitz

npm i https://pkg.pr.new/@builder.io/qwik@8305
npm i https://pkg.pr.new/@builder.io/qwik-city@8305
npm i https://pkg.pr.new/eslint-plugin-qwik@8305
npm i https://pkg.pr.new/create-qwik@8305

commit: 2a61ae7

@maiieul maiieul self-assigned this Feb 6, 2026
@maiieul maiieul added the bug Something isn't working label Feb 6, 2026
@maiieul maiieul moved this from Backlog to Waiting For Review in Qwik Development Feb 6, 2026
Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏

@maiieul maiieul merged commit 8e866a6 into QwikDev:main Feb 6, 2026
49 of 56 checks passed
@github-project-automation github-project-automation bot moved this from Waiting For Review to Done in Qwik Development Feb 6, 2026
@github-actions github-actions bot mentioned this pull request Mar 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants