Conversation
🦋 Changeset detectedLatest commit: bf1285b The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
commit: |
Varixo
reviewed
Mar 9, 2026
Comment on lines
+1658
to
+1660
| if (!_fastNextSibling) { | ||
| _fastNextSibling = fastGetter<typeof _fastNextSibling>(node, 'nextSibling')!; | ||
| } |
Member
There was a problem hiding this comment.
I think we have somewhere that code already? cant we reuse it?
Member
Author
There was a problem hiding this comment.
it depends on if fastFirstChild or fastNextSibling are called first. Not sure how to reuse it here hmm.
Member
There was a problem hiding this comment.
I think you can just call the fast functions. Maybe something needs extracting
packages/qwik/src/core/shared/projection/external-projection.ts
Outdated
Show resolved
Hide resolved
This wraps Qwik components for using inside a qwikified React app, allowing multiple qwik children.
github-project-automation
bot
moved this from Waiting For Review
to Done
in Qwik Development
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reactify$()to make it easy to gradually migrate from React to Qwik