Skip to content

fix(router): make sure css gets found on the correct module graph #8423

Merged
wmertens merged 2 commits intoQwikDev:build/v2from
saboooor:build/v2
Mar 13, 2026
Merged

fix(router): make sure css gets found on the correct module graph #8423
wmertens merged 2 commits intoQwikDev:build/v2from
saboooor:build/v2

Conversation

@saboooor
Copy link
Contributor

What is it?

  • Bug

Description

Fixes an issue with css files not being loaded on dev environment.

Checklist

@saboooor saboooor requested a review from a team as a code owner March 13, 2026 00:52
Copilot AI review requested due to automatic review settings March 13, 2026 00:52
@changeset-bot
Copy link

changeset-bot bot commented Mar 13, 2026

🦋 Changeset detected

Latest commit: 500a739

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes a dev-mode issue in @qwik.dev/router where CSS assets may not be discovered/linked because they exist on a different Vite module graph during initial requests.

Changes:

  • Update CSS URL collection to scan both Vite client and SSR module graphs during dev.
  • Adjust CSS module collection to store final href strings (including ?t= HMR timestamp) directly.
  • Add a changeset to publish a patch release for @qwik.dev/router.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
packages/qwik-router/src/buildtime/vite/dev-middleware.ts Expands dev CSS discovery from client-only module graph to include SSR module graph.
.changeset/tasty-parents-end.md Patch changeset for the router dev CSS fix.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 13, 2026

Open in StackBlitz

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/core@8423
npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/router@8423
npm i https://pkg.pr.new/QwikDev/qwik/eslint-plugin-qwik@8423
npm i https://pkg.pr.new/QwikDev/qwik/create-qwik@8423

commit: 500a739

@github-actions
Copy link
Contributor

github-actions bot commented Mar 13, 2026

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 500a739

Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wmertens wmertens merged commit 0a09004 into QwikDev:build/v2 Mar 13, 2026
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants