fix(router): make sure css gets found on the correct module graph #8423
Merged
wmertens merged 2 commits intoQwikDev:build/v2from Mar 13, 2026
Merged
fix(router): make sure css gets found on the correct module graph #8423wmertens merged 2 commits intoQwikDev:build/v2from
wmertens merged 2 commits intoQwikDev:build/v2from
Conversation
🦋 Changeset detectedLatest commit: 500a739 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Pull request overview
Fixes a dev-mode issue in @qwik.dev/router where CSS assets may not be discovered/linked because they exist on a different Vite module graph during initial requests.
Changes:
- Update CSS URL collection to scan both Vite client and SSR module graphs during dev.
- Adjust CSS module collection to store final
hrefstrings (including?t=HMR timestamp) directly. - Add a changeset to publish a patch release for
@qwik.dev/router.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packages/qwik-router/src/buildtime/vite/dev-middleware.ts | Expands dev CSS discovery from client-only module graph to include SSR module graph. |
| .changeset/tasty-parents-end.md | Patch changeset for the router dev CSS fix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
commit: |
Contributor
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What is it?
Description
Fixes an issue with css files not being loaded on dev environment.
Checklist
pnpm change