fix(qwik-city): check all bundle origins for route imports#8455
Merged
Conversation
🦋 Changeset detectedLatest commit: 8643894 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
returninside theforloop withbundle.origins.some(...)inpackages/qwik-city/src/buildtime/vite/get-route-imports.tsso every origin is checked before deciding membership.packages/qwik-city/src/buildtime/vite/get-route-imports.unit.tsthat verifies bundles with multiple origins are included when a later origin matches the route..changeset/few-geese-approve.mdfor@builder.io/qwik-cityto document the fix.Testing
nodesnippet that exercises the multi-origin case and returned the expectedtrueresult.pnpm vitest run packages/qwik-city/src/buildtime/vite/get-route-imports.unit.ts, but the run failed in this environment due to Node version mismatch (Got: v20.19.6, repo requires>=22.18.0), so the added test could not be executed here.Codex Task