Skip to content

fix(optimizer): prevent exporting variables in few cases#8458

Merged
wmertens merged 2 commits intobuild/v2from
v2-fix-inlining-exported-variables
Mar 20, 2026
Merged

fix(optimizer): prevent exporting variables in few cases#8458
wmertens merged 2 commits intobuild/v2from
v2-fix-inlining-exported-variables

Conversation

@Varixo
Copy link
Member

@Varixo Varixo commented Mar 20, 2026

  • prevent inlining of exported variables into segments
  • prevent auto-export of shadowed variables in various constructs

@Varixo Varixo self-assigned this Mar 20, 2026
@Varixo Varixo added the V2 label Mar 20, 2026
@changeset-bot
Copy link

changeset-bot bot commented Mar 20, 2026

🦋 Changeset detected

Latest commit: 8100990

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@maiieul maiieul moved this from Backlog to In progress in Qwik Development Mar 20, 2026
@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 20, 2026

Open in StackBlitz

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/core@8458
npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/router@8458
npm i https://pkg.pr.new/QwikDev/qwik/eslint-plugin-qwik@8458
npm i https://pkg.pr.new/QwikDev/qwik/create-qwik@8458

commit: 7f72686

@github-actions
Copy link
Contributor

github-actions bot commented Mar 20, 2026

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 8100990

@Varixo Varixo marked this pull request as ready for review March 20, 2026 21:54
@Varixo Varixo requested a review from a team as a code owner March 20, 2026 21:54
@maiieul maiieul moved this from In progress to Waiting For Review in Qwik Development Mar 20, 2026
@Varixo Varixo changed the title fix(optimizer): prevent inlining of exported variables into segments fix(optimizer): prevent exporting variables in few cases Mar 20, 2026
@Varixo Varixo force-pushed the v2-fix-inlining-exported-variables branch from 7f72686 to 8100990 Compare March 20, 2026 22:02
Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wmertens wmertens enabled auto-merge March 20, 2026 22:15
@wmertens wmertens merged commit 3f01571 into build/v2 Mar 20, 2026
46 of 49 checks passed
@wmertens wmertens deleted the v2-fix-inlining-exported-variables branch March 20, 2026 22:30
@github-project-automation github-project-automation bot moved this from Waiting For Review to Done in Qwik Development Mar 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants