Skip to content

fix(optimizer): shared root bindings#8500

Merged
wmertens merged 2 commits intobuild/v2from
v2-shared-root-bindings
Mar 30, 2026
Merged

fix(optimizer): shared root bindings#8500
wmertens merged 2 commits intobuild/v2from
v2-shared-root-bindings

Conversation

@Varixo
Copy link
Copy Markdown
Member

@Varixo Varixo commented Mar 28, 2026

Root-level variables could be incorrectly moved into extracted QRL chunks even when still needed by the main module

@Varixo Varixo self-assigned this Mar 28, 2026
@Varixo Varixo requested a review from a team as a code owner March 28, 2026 09:54
@Varixo Varixo added the V2 label Mar 28, 2026
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 28, 2026

🦋 Changeset detected

Latest commit: 1f0680d

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@maiieul maiieul moved this from Backlog to Waiting For Review in Qwik Development Mar 28, 2026
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Mar 28, 2026

Open in StackBlitz

@qwik.dev/core

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/core@8500

@qwik.dev/router

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/router@8500

eslint-plugin-qwik

npm i https://pkg.pr.new/QwikDev/qwik/eslint-plugin-qwik@8500

create-qwik

npm i https://pkg.pr.new/QwikDev/qwik/create-qwik@8500

@qwik.dev/optimizer

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/optimizer@8500

commit: 1f0680d

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 28, 2026

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 1f0680d

Copy link
Copy Markdown
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wmertens wmertens merged commit 7afcdb7 into build/v2 Mar 30, 2026
27 checks passed
@wmertens wmertens deleted the v2-shared-root-bindings branch March 30, 2026 05:29
@github-project-automation github-project-automation bot moved this from Waiting For Review to Done in Qwik Development Mar 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants