Skip to content

fix(vite): skip qwikloader emitFile in serve mode#8512

Merged
wmertens merged 2 commits intoQwikDev:build/v2from
SchahinRohani:fix/vite-serve-emitfile-warning
Apr 2, 2026
Merged

fix(vite): skip qwikloader emitFile in serve mode#8512
wmertens merged 2 commits intoQwikDev:build/v2from
SchahinRohani:fix/vite-serve-emitfile-warning

Conversation

@SchahinRohani
Copy link
Copy Markdown

@SchahinRohani SchahinRohani commented Apr 1, 2026

What is it?

  • Bug

Description

When running Qwik with Vite in dev/serve mode, the plugin was calling emitFile() for the qwikloader, which leads to the following warning:

[plugin:vite-plugin-qwik] context method emitFile() is not supported in serve mode.
This plugin is likely not vite-compatible.

The same !devServer guard is already used in the transform hook to skip emitFile() during dev. This change applies the same pattern to buildStart, where the qwikloader chunk emission was missing the guard.

Checklist

  • My code follows the developer guidelines of this project
  • I performed a self-review of my own code
  • I added a changeset with pnpm change
  • I made corresponding changes to the Qwik docs
  • I added new tests to cover the fix / functionality

@SchahinRohani SchahinRohani requested a review from a team as a code owner April 1, 2026 18:58
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 1, 2026

🦋 Changeset detected

Latest commit: f715fae

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Copy Markdown
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wmertens wmertens enabled auto-merge April 1, 2026 22:24
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Apr 1, 2026

Open in StackBlitz

@qwik.dev/core

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/core@8512

@qwik.dev/router

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/router@8512

eslint-plugin-qwik

npm i https://pkg.pr.new/QwikDev/qwik/eslint-plugin-qwik@8512

create-qwik

npm i https://pkg.pr.new/QwikDev/qwik/create-qwik@8512

@qwik.dev/optimizer

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/optimizer@8512

commit: dabcbdf

@SchahinRohani
Copy link
Copy Markdown
Author

SchahinRohani commented Apr 1, 2026

Hey @wmertens, CI is failing on pnpm dedupe --check which seems pre-existing on build/v2. Let me know if there's anything I can do on my end, happy to rebase or help fix it.

@wmertens wmertens merged commit dd6d11e into QwikDev:build/v2 Apr 2, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants