fix(vite): skip qwikloader emitFile in serve mode#8512
Merged
wmertens merged 2 commits intoQwikDev:build/v2from Apr 2, 2026
Merged
fix(vite): skip qwikloader emitFile in serve mode#8512wmertens merged 2 commits intoQwikDev:build/v2from
wmertens merged 2 commits intoQwikDev:build/v2from
Conversation
🦋 Changeset detectedLatest commit: f715fae The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@qwik.dev/core
@qwik.dev/router
eslint-plugin-qwik
create-qwik
@qwik.dev/optimizer
commit: |
Author
|
Hey @wmertens, CI is failing on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What is it?
Description
When running Qwik with Vite in dev/serve mode, the plugin was calling
emitFile()for the qwikloader, which leads to the following warning:The same !devServer guard is already used in the transform hook to skip emitFile() during dev. This change applies the same pattern to buildStart, where the qwikloader chunk emission was missing the guard.
Checklist
pnpm change