Skip to content

refactor: cleanup preloader#8518

Merged
wmertens merged 15 commits intobuild/v2from
cleanup-preloader-queue
Apr 22, 2026
Merged

refactor: cleanup preloader#8518
wmertens merged 15 commits intobuild/v2from
cleanup-preloader-queue

Conversation

@maiieul
Copy link
Copy Markdown
Member

@maiieul maiieul commented Apr 3, 2026

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos
  • Infra

Description

Removing old SW deprecated APIs as well as unnecessary preloader ones. Cleaning up old logic to reduce code size and make it easier to inline the preloader logic in a future refactor.

Checklist

  • My code follows the developer guidelines of this project
  • I performed a self-review of my own code
  • I added a changeset with pnpm change
  • I made corresponding changes to the Qwik docs
  • I added new tests to cover the fix / functionality

@maiieul maiieul requested a review from a team as a code owner April 3, 2026 11:54
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 3, 2026

🦋 Changeset detected

Latest commit: 767bfc1

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@maiieul maiieul self-assigned this Apr 3, 2026
@maiieul maiieul moved this to Waiting For Review in Qwik Development Apr 3, 2026
@maiieul maiieul marked this pull request as draft April 3, 2026 12:14
@maiieul maiieul moved this from Waiting For Review to In progress in Qwik Development Apr 3, 2026
@maiieul maiieul force-pushed the cleanup-preloader-queue branch from a50429b to 2404ee4 Compare April 3, 2026 12:17
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 3, 2026

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 767bfc1

@maiieul maiieul force-pushed the cleanup-preloader-queue branch 2 times, most recently from 1664964 to 7a00e94 Compare April 3, 2026 15:33
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Apr 6, 2026

Open in StackBlitz

@qwik.dev/core

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/core@8518

@qwik.dev/router

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/router@8518

eslint-plugin-qwik

npm i https://pkg.pr.new/QwikDev/qwik/eslint-plugin-qwik@8518

create-qwik

npm i https://pkg.pr.new/QwikDev/qwik/create-qwik@8518

@qwik.dev/optimizer

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/optimizer@8518

commit: 767bfc1

@maiieul maiieul force-pushed the cleanup-preloader-queue branch 2 times, most recently from 3921b72 to dc93fbd Compare April 6, 2026 13:58
@maiieul maiieul changed the title refactor: cleanup queue.ts refactor: cleanup preloader Apr 6, 2026
@maiieul maiieul added the V2 label Apr 6, 2026
@maiieul maiieul marked this pull request as ready for review April 6, 2026 14:48
@maiieul maiieul requested review from a team as code owners April 6, 2026 14:48
@maiieul maiieul moved this from In progress to Waiting For Review in Qwik Development Apr 6, 2026
@maiieul maiieul force-pushed the cleanup-preloader-queue branch 4 times, most recently from 1b26a5a to 83a2dcb Compare April 20, 2026 10:57
Copy link
Copy Markdown
Member

@Varixo Varixo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maiieul maiieul force-pushed the cleanup-preloader-queue branch from 83a2dcb to 767bfc1 Compare April 22, 2026 13:33
Copy link
Copy Markdown
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wmertens wmertens merged commit 8e07b9b into build/v2 Apr 22, 2026
28 checks passed
@github-project-automation github-project-automation Bot moved this from Waiting For Review to Done in Qwik Development Apr 22, 2026
@wmertens wmertens deleted the cleanup-preloader-queue branch April 22, 2026 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants