Skip to content

fix(e2e ssg): state char count can change a little#8556

Merged
wmertens merged 1 commit intobuild/v2from
fix-ssg-e2e
Apr 13, 2026
Merged

fix(e2e ssg): state char count can change a little#8556
wmertens merged 1 commit intobuild/v2from
fix-ssg-e2e

Conversation

@wmertens
Copy link
Copy Markdown
Member

No description provided.

@wmertens wmertens requested a review from a team as a code owner April 13, 2026 21:08
Copilot AI review requested due to automatic review settings April 13, 2026 21:08
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 13, 2026

⚠️ No Changeset found

Latest commit: e6f79bb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@wmertens wmertens merged commit fcee816 into build/v2 Apr 13, 2026
4 checks passed
@maiieul maiieul moved this to Waiting For Review in Qwik Development Apr 13, 2026
@wmertens wmertens deleted the fix-ssg-e2e branch April 13, 2026 21:08
@github-project-automation github-project-automation bot moved this from Waiting For Review to Done in Qwik Development Apr 13, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the SSG snapshot E2E test to ignore the _dumpState() trailing character-count line so that small state-size fluctuations don’t fail the snapshot comparison.

Changes:

  • Strip the (<n> chars) line from the normalized state dump in the E2E test.
  • Update the checked-in expected state snapshot to remove the previously included char-count line.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
e2e/qwik-e2e/tests/qwikrouter/ssg-snapshot.e2e.ts Normalizes _dumpState() output by removing the trailing (<n> chars) line before snapshot comparison.
e2e/qwik-e2e/apps/qwikrouter-ssg-snapshot/expected.state.txt Removes the trailing char-count line to match the new normalization behavior.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants