Skip to content

Fixes #8564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wmertens merged 2 commits into from
Apr 17, 2026
+15 −7
Merged

Fixes #8564

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
00bff27
fix(core): correct error anchor
wmertens Apr 17, 2026
f8e23a4
chore(e2e): always warn about ssg size inc
wmertens Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions e2e/qwik-e2e/tests/qwikrouter/ssg-snapshot.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,17 +35,25 @@ test.describe('router ssg snapshot', () => {
manifestHash
);

let expectedHtml = (await readFile(expectedHtmlPath, 'utf-8').catch(() => '')).replace(
/\r\n/g,
'\n'
);
let expectedState = (await readFile(expectedStatePath, 'utf-8').catch(() => '')).replace(
/\r\n/g,
'\n'
);

warnIfSizeChanged('readable state dump', expectedState, normalizedState);
warnIfSizeChanged('HTML', expectedHtml, normalizedHtml);

if (process.env.UPDATE_SSG_SNAPSHOT === '1') {
await writeFile(expectedHtmlPath, normalizedHtml, 'utf-8');
await writeFile(expectedStatePath, normalizedState, 'utf-8');
expectedHtml = normalizedHtml;
expectedState = normalizedState;
}

const expectedHtml = (await readFile(expectedHtmlPath, 'utf-8')).replace(/\r\n/g, '\n');
const expectedState = (await readFile(expectedStatePath, 'utf-8')).replace(/\r\n/g, '\n');

warnIfSizeChanged('readable state dump', expectedState, normalizedState);
warnIfSizeChanged('HTML', expectedHtml, normalizedHtml);

expect(normalizedState).toEqual(expectedState);
expect(normalizedHtml).toEqual(expectedHtml);
});
Expand Down
2 changes: 1 addition & 1 deletion packages/qwik/src/core/shared/error/error.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { logErrorAndStop } from '../utils/log';
import { qDev } from '../utils/qdev';
import { isObject } from '../utils/types';

const baseUrl = 'https://qwikdev-build-v2.qwik-8nx.pages.dev/docs/errors/#Q';
const baseUrl = 'https://qwikdev-build-v2.qwik-8nx.pages.dev/docs/errors/#q';
export const codeToText = (code: number, ...parts: any[]): string => {
if (qDev) {
// Keep one error, one line to make it easier to search for the error message.
Expand Down
Loading