Skip to content

fix(qwik-city): sort server plugins#8568

Merged
wmertens merged 1 commit into
mainfrom
sort-server-plugins
Apr 30, 2026
Merged

fix(qwik-city): sort server plugins#8568
wmertens merged 1 commit into
mainfrom
sort-server-plugins

Conversation

@wmertens
Copy link
Copy Markdown
Member

Ensure that server plugins run in alphabetical order

Copilot AI review requested due to automatic review settings April 22, 2026 11:10
@wmertens wmertens requested a review from a team as a code owner April 22, 2026 11:10
@wmertens wmertens enabled auto-merge April 22, 2026 11:10
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 22, 2026

🦋 Changeset detected

Latest commit: 726e930

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@builder.io/qwik-city Minor
eslint-plugin-qwik Minor
@builder.io/qwik Minor
create-qwik Minor
@builder.io/qwik-react Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR makes server plugin execution deterministic by explicitly sorting discovered server plugin modules, rather than relying on filesystem directory traversal order.

Changes:

  • Sort walkServerPlugins() results by filePath before returning.
  • Add a unit test asserting ctx.serverPlugins are returned in sorted order.
  • Add a changeset entry documenting the behavior change.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
packages/qwik-city/src/buildtime/routing/walk-server-plugins.ts Explicitly sorts server plugin discovery output by filePath.
packages/qwik-city/src/buildtime/routing/walk-server-plugins.unit.ts Adds regression test for deterministic server plugin ordering.
.changeset/old-mails-swim.md Adds release note for the plugin ordering fix.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/qwik-city/src/buildtime/routing/walk-server-plugins.ts
Comment thread .changeset/old-mails-swim.md
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Apr 22, 2026

Open in StackBlitz

npm i https://pkg.pr.new/@builder.io/qwik@8568
npm i https://pkg.pr.new/@builder.io/qwik-city@8568
npm i https://pkg.pr.new/eslint-plugin-qwik@8568
npm i https://pkg.pr.new/create-qwik@8568

commit: 726e930

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 22, 2026

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 726e930

@wmertens wmertens disabled auto-merge April 30, 2026 13:33
@wmertens wmertens merged commit 3862007 into main Apr 30, 2026
29 checks passed
@wmertens wmertens deleted the sort-server-plugins branch April 30, 2026 13:34
@github-project-automation github-project-automation Bot moved this from Waiting For Review to Done in Qwik Development Apr 30, 2026
@github-actions github-actions Bot mentioned this pull request May 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants