fix(qwik-city): sort server plugins#8568
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 726e930 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Pull request overview
This PR makes server plugin execution deterministic by explicitly sorting discovered server plugin modules, rather than relying on filesystem directory traversal order.
Changes:
- Sort
walkServerPlugins()results byfilePathbefore returning. - Add a unit test asserting
ctx.serverPluginsare returned in sorted order. - Add a changeset entry documenting the behavior change.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packages/qwik-city/src/buildtime/routing/walk-server-plugins.ts | Explicitly sorts server plugin discovery output by filePath. |
| packages/qwik-city/src/buildtime/routing/walk-server-plugins.unit.ts | Adds regression test for deterministic server plugin ordering. |
| .changeset/old-mails-swim.md | Adds release note for the plugin ordering fix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
commit: |
Contributor
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure that server plugins run in alphabetical order